Rev 4428: tried a different tack, to use a new list and append. in http://bazaar.launchpad.net/~jameinel/bzr/jam-gdfo-heads

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/jam-gdfo-heads

------------------------------------------------------------
revno: 4428
revision-id: john at arbash-meinel.com-20090619173033-0opvbm5ubonl0jo2
parent: john at arbash-meinel.com-20090619172010-1g5aj28byaxko408
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: jam-gdfo-heads
timestamp: Fri 2009-06-19 12:30:33 -0500
message:
  tried a different tack, to use a new list and append.
  
  This would cause us to tend to walk from low gdfo to high gdfo, but it
  didn't seem to be a big win.
-------------- next part --------------
=== modified file 'bzrlib/_known_graph_pyx.pyx'
--- a/bzrlib/_known_graph_pyx.pyx	2009-06-19 17:20:10 +0000
+++ b/bzrlib/_known_graph_pyx.pyx	2009-06-19 17:30:33 +0000
@@ -247,8 +247,7 @@
                 if child.gdfo is None or node.gdfo + 1 > child.gdfo:
                     child.gdfo = node.gdfo + 1
                 if known_gdfo == PyList_GET_SIZE(child.parents):
-                    # We are the last parent updating that node, we can
-                    # continue from there
+                    # This child is populated, queue it to be walked
                     if replace:
                         replace = 0
                         Py_INCREF(child) # SetItem steals a ref
@@ -257,8 +256,7 @@
                         PyList_Append(pending, child)
                         pending_size = pending_size + 1
             if replace:
-                # We didn't add any more children, so just pop off the last
-                # node
+                # We didn't add any children, so pop off the last node
                 pending.pop()
                 pending_size = pending_size - 1