Rev 4420: Simplify gdfo computing by finding tails when at graph build time. in file:///home/vila/src/bzr/experimental/vila-better-heads/

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Vincent Ladeuil wrote:
>> At file:///home/vila/src/bzr/experimental/vila-better-heads/
> 
>> ------------------------------------------------------------
>> revno: 4420
>> revision-id: v.ladeuil+lp at free.fr-20090618182610-o59r8149nlzb3b68
>> parent: v.ladeuil+lp at free.fr-20090618141237-k9u7mrithzstg15z
>> committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
>> branch nick: vila-better-heads
>> timestamp: Thu 2009-06-18 20:26:10 +0200
>> message:
>>   Simplify gdfo computing by finding tails when at graph build time.
> 
>>   * bzrlib/_known_graph_pyx.pyx:
>>   (KnownGraph._get_or_create_node): We need to know if the ndoe as
>>   created.
>>   (KnownGraph._initialize_nodes): Calulate tails ahead of time to
>>   intialize gdfo computing.
>>   (KnownGraph._find_gdfo): Use tails directly.
> 
>>   * bzrlib/_known_graph_py.py:
>>   (KnownGraph._initialize_nodes): Calulate tails ahead of time to
>>   intialize gdfo computing.
>>   (KnownGraph._find_gdfo): Use tails directly.
> 
> 
> 
>          for key, parent_keys in parent_map.iteritems():
>              if key in nodes:
>                  node = nodes[key]
>                  node.parent_keys = parent_keys
> +                if parent_keys:
> +                    # This node has been added before being seen in
> parent_map
> +                    # (see below)
> +                    tails.remove(node)
> 
> 
> ^- should be "if parent_keys is not None"
> 
> The first revision can have parent_keys == () and still not be a ghost.
> 
> John
> =:->
> 

Oops, I forgot, this is tails check, not a ghosts check. And the
revision is still a tail.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAko6iAMACgkQJdeBCYSNAAMapwCYw3YcE3tQWxtZG+oMc7/UoUoF
egCgn6NP74v4IJSe5O+hKILd0FkjgLo=
=DHYd
-----END PGP SIGNATURE-----