Rev 4376: It seems that fetch() no longer returns the number of revisions fetched. in http://bazaar.launchpad.net/~jameinel/bzr/1.15-pack-source
John Arbash Meinel
john at arbash-meinel.com
Wed Jun 17 20:08:34 BST 2009
At http://bazaar.launchpad.net/~jameinel/bzr/1.15-pack-source
------------------------------------------------------------
revno: 4376
revision-id: john at arbash-meinel.com-20090617190825-ktfk82li57rf2im6
parent: john at arbash-meinel.com-20090617175910-7h37mzgovxh0fabn
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 1.15-pack-source
timestamp: Wed 2009-06-17 14:08:25 -0500
message:
It seems that fetch() no longer returns the number of revisions fetched.
It still does for *some* InterRepository fetch paths, but the generic one does not.
It is also not easy to get it to, since the Source and Sink are the ones
that would know how many keys were transmitted, and they are potentially 'remote'
objects.
This was also only tested to occur as a by-product in a random 'test_commit' test.
I assume if we really wanted the assurance, we would have a per_repo or interrepo
test for it.
-------------- next part --------------
=== modified file 'bzrlib/tests/test_commit_merge.py'
--- a/bzrlib/tests/test_commit_merge.py 2009-03-23 14:59:43 +0000
+++ b/bzrlib/tests/test_commit_merge.py 2009-06-17 19:08:25 +0000
@@ -46,7 +46,7 @@
wtx.commit('commit one', rev_id='x at u-0-1', allow_pointless=True)
wty.commit('commit two', rev_id='y at u-0-1', allow_pointless=True)
- self.assertEqual((1, []), by.fetch(bx))
+ by.fetch(bx)
# just having the history there does nothing
self.assertRaises(PointlessCommit,
wty.commit,
More information about the bazaar-commits
mailing list