Rev 4514: (bialix) launchpad plugin: import webbrowse should be explicit and in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

Canonical.com Patch Queue Manager pqm at pqm.ubuntu.com
Tue Jul 7 11:57:38 BST 2009


At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 4514 [merge]
revision-id: pqm at pqm.ubuntu.com-20090707105737-6s1x97fbhihlpvli
parent: pqm at pqm.ubuntu.com-20090707053221-1qcpid9iya2ema6p
parent: bialix at ukr.net-20090706130023-lfw6193bujx65hj3
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Tue 2009-07-07 11:57:37 +0100
message:
  (bialix) launchpad plugin: import webbrowse should be explicit and
  	never lazy, otherwise bzr.exe lacks this module.
modified:
  bzrlib/plugins/launchpad/__init__.py __init__.py-20060315182712-2d5feebd2a1032dc
=== modified file 'bzrlib/plugins/launchpad/__init__.py'
--- a/bzrlib/plugins/launchpad/__init__.py	2009-07-03 08:57:53 +0000
+++ b/bzrlib/plugins/launchpad/__init__.py	2009-07-06 13:00:23 +0000
@@ -26,8 +26,6 @@
 
 from bzrlib.lazy_import import lazy_import
 lazy_import(globals(), """
-import webbrowser
-
 from bzrlib import (
     branch as _mod_branch,
     trace,
@@ -196,6 +194,8 @@
         web_url = self._get_web_url(LaunchpadService(), location)
         trace.note('Opening %s in web browser' % web_url)
         if not dry_run:
+            import webbrowser   # this import should not be lazy
+                                # otherwise bzr.exe lacks this module
             webbrowser.open(web_url)
 
 register_command(cmd_launchpad_open)




More information about the bazaar-commits mailing list