Rev 4524: Some comments about the PreviewTree.annotate_iter implementation. in http://bazaar.launchpad.net/~jameinel/bzr/1.17-rework-annotate

John Arbash Meinel john at arbash-meinel.com
Mon Jul 6 22:23:13 BST 2009


At http://bazaar.launchpad.net/~jameinel/bzr/1.17-rework-annotate

------------------------------------------------------------
revno: 4524
revision-id: john at arbash-meinel.com-20090706212245-eeh0xp8izenxb8aq
parent: john at arbash-meinel.com-20090706211812-1w3mteni33dhv2kh
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 1.17-rework-annotate
timestamp: Mon 2009-07-06 16:22:45 -0500
message:
  Some comments about the PreviewTree.annotate_iter implementation.
-------------- next part --------------
=== modified file 'bzrlib/transform.py'
--- a/bzrlib/transform.py	2009-07-06 18:57:02 +0000
+++ b/bzrlib/transform.py	2009-07-06 21:22:45 +0000
@@ -1962,6 +1962,13 @@
             return old_annotation
         if not changed_content:
             return old_annotation
+        # TODO: This is doing something similar to what WT.annotate_iter is
+        #       doing, however it fails slightly because it doesn't know what
+        #       the *other* revision_id is, so it doesn't know how to give the
+        #       other as the origin for some lines, they all get
+        #       'default_revision'
+        #       It would be nice to be able to use the new Annotator based
+        #       approach, as well.
         return annotate.reannotate([old_annotation],
                                    self.get_file(file_id).readlines(),
                                    default_revision)



More information about the bazaar-commits mailing list