Rev 3824: Add a TODO, something worth evaluating. in http://bzr.arbash-meinel.com/branches/bzr/brisbane/look_before_you_leap

[John Arbash Meinel]

At http://bzr.arbash-meinel.com/branches/bzr/brisbane/look_before_you_leap

------------------------------------------------------------
revno: 3824
revision-id: john at arbash-meinel.com-20090218180341-d7arrtdfuhfnm0yy
parent: john at arbash-meinel.com-20090218175014-4meosz28tb6ws5qf
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: look_before_you_leap
timestamp: Wed 2009-02-18 12:03:41 -0600
message:
  Add a TODO, something worth evaluating.
-------------- next part --------------
=== modified file 'bzrlib/chk_map.py'
--- a/bzrlib/chk_map.py	2009-02-18 17:50:14 +0000
+++ b/bzrlib/chk_map.py	2009-02-18 18:03:41 +0000
@@ -1096,6 +1096,9 @@
         key = ('sha1:' + sha1,)
         if not store.has_key(key):
             store.add_lines(key, (), lines, random_id=True)
+        # TODO: Do we want to add the bytes to the page cache if they aren't
+        #       new? Or should we only call _page_cache.add when we call
+        #       add_lines()?
         self._key = key
         _page_cache.add(self._key, ''.join(lines))
         yield self._key