Rev 4015: Make the ratchet aspect of the blackbox smart server push acceptance tests clearer. in http://people.ubuntu.com/~robertc/baz2.0/push.roundtrips

Robert Collins robertc at robertcollins.net
Wed Feb 18 04:21:07 GMT 2009


At http://people.ubuntu.com/~robertc/baz2.0/push.roundtrips

------------------------------------------------------------
revno: 4015
revision-id: robertc at robertcollins.net-20090218042104-pf0hqv2bje74rvd1
parent: robertc at robertcollins.net-20090218041442-k28bhmqhwko728u5
committer: Robert Collins <robertc at robertcollins.net>
branch nick: push.roundtrips
timestamp: Wed 2009-02-18 15:21:04 +1100
message:
  Make the ratchet aspect of the blackbox smart server push acceptance tests clearer.
=== modified file 'bzrlib/tests/blackbox/test_push.py'
--- a/bzrlib/tests/blackbox/test_push.py	2009-02-18 04:14:42 +0000
+++ b/bzrlib/tests/blackbox/test_push.py	2009-02-18 04:21:04 +0000
@@ -198,6 +198,11 @@
         self._reset_smart_call_log()
         self.run_bzr(['push', self.get_url('to-one')], working_dir='from')
         rpc_count = len(self.hpss_calls)
+        # This figure represent the amount of work to perform this use case. It
+        # is entirely ok to reduce this number if a test fails due to rpc_count
+        # being too low. If rpc_count increases, more network roundtrips have
+        # become necessary for this use case. Please do not adjust this number
+        # upwards without agreement from bzr's network support maintainers.
         self.assertEqual(107, rpc_count)
 
     def test_push_smart_stacked_streaming_acceptance(self):
@@ -210,6 +215,11 @@
         self.run_bzr(['push', '--stacked', '--stacked-on', '../parent',
             self.get_url('public')], working_dir='local')
         rpc_count = len(self.hpss_calls)
+        # This figure represent the amount of work to perform this use case. It
+        # is entirely ok to reduce this number if a test fails due to rpc_count
+        # being too low. If rpc_count increases, more network roundtrips have
+        # become necessary for this use case. Please do not adjust this number
+        # upwards without agreement from bzr's network support maintainers.
         self.assertEqual(132, rpc_count)
         remote = Branch.open('public')
         self.assertEndsWith(remote.get_stacked_on_url(), '/parent')




More information about the bazaar-commits mailing list