Rev 4009: (Jelmer) Use Repository.get_revision_delta() in 'bzr missing -v' in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 4009
revision-id: pqm at pqm.ubuntu.com-20090215032052-9749wepsy6dgnq9l
parent: pqm at pqm.ubuntu.com-20090214165408-vlwzj9x1qax0i1b0
parent: jelmer at samba.org-20090214182126-idmhgwihjegufqah
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Sun 2009-02-15 03:20:52 +0000
message:
  (Jelmer) Use Repository.get_revision_delta() in 'bzr missing -v'
  	rather than doing the delta locally. (#315048)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/missing.py              missing.py-20050812153334-097f7097e2a8bcd1
    ------------------------------------------------------------
    revno: 4007.1.1
    revision-id: jelmer at samba.org-20090214182126-idmhgwihjegufqah
    parent: pqm at pqm.ubuntu.com-20090213220525-f4o6y76g5mjtxb7k
    committer: Jelmer Vernooij <jelmer at samba.org>
    branch nick: bzr.dev
    timestamp: Sat 2009-02-14 19:21:26 +0100
    message:
      Use Repository.get_revision_delta() in missing rather than doing the delta
      ourselves.
    modified:
      NEWS                           NEWS-20050323055033-4e00b5db738777ff
      bzrlib/missing.py              missing.py-20050812153334-097f7097e2a8bcd1
=== modified file 'NEWS'
--- a/NEWS	2009-02-13 21:21:25 +0000
+++ b/NEWS	2009-02-14 18:21:26 +0000
@@ -28,6 +28,10 @@
     * ``bzr unshelve`` gives a more palatable error if passed a non-integer
       shelf id. (Daniel Watkins)
 
+    * ``bzr missing`` now uses ``Repository.get_revision_delta()`` rather
+      than fetching trees and determining a delta itself. (Jelmer
+      Vernooij, #315048)
+
   DOCUMENTATION:
 
     * The documentation for ``shelve`` and ``unshelve`` has been clarified.

=== modified file 'bzrlib/missing.py'
--- a/bzrlib/missing.py	2009-01-01 23:21:07 +0000
+++ b/bzrlib/missing.py	2009-02-14 18:21:26 +0000
@@ -37,16 +37,7 @@
             revno, rev_id, merge_depth = rev
         rev = revision_source.get_revision(rev_id)
         if verbose:
-            remote_tree = revision_source.revision_tree(rev_id)
-            parent_rev_id = rev.parent_ids[0]
-            if last_rev_id == parent_rev_id:
-                parent_tree = last_tree
-            else:
-                parent_tree = revision_source.revision_tree(parent_rev_id)
-            revision_tree = revision_source.revision_tree(rev_id)
-            last_rev_id = rev_id
-            last_tree = revision_tree
-            delta = revision_tree.changes_from(parent_tree)
+            delta = revision_source.get_revision_delta(rev_id)
         else:
             delta = None
         yield log.LogRevision(rev, revno, merge_depth, delta=delta)