Rev 3992: Fixed as per Martin's review. in file:///net/bigmamac/Volumes/home/vila/src/bzr/bugs/httplib-broken-readline/

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Feb 10 09:19:26 GMT 2009


At file:///net/bigmamac/Volumes/home/vila/src/bzr/bugs/httplib-broken-readline/

------------------------------------------------------------
revno: 3992
revision-id: v.ladeuil+lp at free.fr-20090210091925-hog86ju0m3doty42
parent: v.ladeuil+lp at free.fr-20090210091139-se2d9d3nb8twp0yy
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: httplib-broken-readline
timestamp: Tue 2009-02-10 10:19:25 +0100
message:
  Fixed as per Martin's review.
  
  * bzrlib/tests/test_read_bundle.py:
  (TestDeprecations.create_test_bundle,
  TestReadBundleFromURL.create_test_bundle): Add try/finally around
  f.write.
-------------- next part --------------
=== modified file 'bzrlib/tests/test_read_bundle.py'
--- a/bzrlib/tests/test_read_bundle.py	2009-02-09 18:25:43 +0000
+++ b/bzrlib/tests/test_read_bundle.py	2009-02-10 09:19:25 +0000
@@ -72,8 +72,10 @@
     def create_test_bundle(self):
         out, wt = create_bundle_file(self)
         f = open('test_bundle', 'wb')
-        f.write(out.getvalue())
-        f.close()
+        try:
+            f.write(out.getvalue())
+        finally:
+            f.close()
         return wt
 
     def test_read_bundle_from_url_deprecated(self):
@@ -96,8 +98,10 @@
         out, wt = create_bundle_file(self)
         if self.get_transport().is_readonly():
             f = open('test_bundle', 'wb')
-            f.write(out.getvalue())
-            f.close()
+            try:
+                f.write(out.getvalue())
+            finally:
+                f.close()
         else:
             self.get_transport().put_file('test_bundle', out)
             self.log('Put to: %s', self.get_url('test_bundle'))



More information about the bazaar-commits mailing list