Rev 4626: Note how much time we spend to reverse the sorted-nodes list in http://bazaar.launchpad.net/~jameinel/bzr/1.19-known-graph-sorted

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/1.19-known-graph-sorted

------------------------------------------------------------
revno: 4626
revision-id: john at arbash-meinel.com-20090816163403-e94dowrraajvf1s4
parent: john at arbash-meinel.com-20090816163005-owo9jl07h6xlnip1
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 1.19-known-graph-sorted
timestamp: Sun 2009-08-16 11:34:03 -0500
message:
  Note how much time we spend to reverse the sorted-nodes list
  and create the final tuple representation.
  A good guess is that the bulk of the rest of the time is spent in actually
  allocating the new MergeNode objects.
-------------- next part --------------
=== modified file 'bzrlib/_known_graph_pyx.pyx'
--- a/bzrlib/_known_graph_pyx.pyx	2009-08-16 16:30:05 +0000
+++ b/bzrlib/_known_graph_pyx.pyx	2009-08-16 16:34:03 +0000
@@ -664,6 +664,9 @@
 
         # We've set up the basic schedule, now we can continue processing the
         # output.
+        # TODO: This final loop costs us 55ms => 41.2ms (14ms) on bzr.dev, to
+        #       evaluate end-of-merge and convert the internal Object
+        #       representation into a Tuple representation...
         sequence_number = 0
         ordered = []
         pos = PyList_GET_SIZE(self._scheduled_nodes) - 1