Rev 37: Long forgotten, approved, local patch fixing test suite failures in file:///v/home/vila/.bazaar/plugins/email/

[Vincent Ladeuil]

At file:///v/home/vila/.bazaar/plugins/email/

------------------------------------------------------------
revno: 37
revision-id: v.ladeuil+lp at free.fr-20080925101927-m93y89e718a1vtq6
parent: jelmer at samba.org-20080805215127-f39s078p0837pku9
parent: v.ladeuil+lp at free.fr-20080521083945-4mvpgin6wkfmwsxq
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: email
timestamp: Thu 2008-09-25 12:19:27 +0200
message:
  Long forgotten, approved, local patch fixing test suite failures
modified:
  emailer.py                     emailer.py-20070123220937-ec5y2n2oeoa0p4ue-1
    ------------------------------------------------------------
    revno: 33.1.2
    revision-id: v.ladeuil+lp at free.fr-20080521083945-4mvpgin6wkfmwsxq
    parent: v.ladeuil+lp at free.fr-20080521072748-y7jeky3yw8kbf7ko
    committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
    branch nick: email
    timestamp: Wed 2008-05-21 10:39:45 +0200
    message:
      Fixed as per Robert's review.
      
      * tests/testemail.py:
      (TestGetTo.test_should_send): Revert previous changes.
      
      * emailer.py:
      (EmailSender.should_send): Return a boolean.
    modified:
      emailer.py                     emailer.py-20070123220937-ec5y2n2oeoa0p4ue-1
      tests/testemail.py             testpublish.py-20051018071212-e3a53d78c05e0e0a
    ------------------------------------------------------------
    revno: 33.1.1
    revision-id: v.ladeuil+lp at free.fr-20080521072748-y7jeky3yw8kbf7ko
    parent: john at arbash-meinel.com-20080501225950-1qerrg9fp54ifmel
    committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
    branch nick: email
    timestamp: Wed 2008-05-21 09:27:48 +0200
    message:
      should_send does not always return a boolean anymore.
      
      * testemail.py:
      Make the test suite pass again.
    modified:
      tests/testemail.py             testpublish.py-20051018071212-e3a53d78c05e0e0a
-------------- next part --------------
=== modified file 'emailer.py'
--- a/emailer.py	2008-06-05 17:40:57 +0000
+++ b/emailer.py	2008-09-25 10:19:27 +0000
@@ -230,7 +230,7 @@
                                             self.diff_filename())
 
     def should_send(self):
-        return self.to() and self.from_address()
+        return bool(self.to() and self.from_address())
 
     def send_maybe(self):
         if self.should_send():