Rev 3689: Properly append the data to the list buffer. in http://bzr.arbash-meinel.com/branches/bzr/jam-integration
John Arbash Meinel
john at arbash-meinel.com
Thu Sep 4 03:42:43 BST 2008
At http://bzr.arbash-meinel.com/branches/bzr/jam-integration
------------------------------------------------------------
revno: 3689
revision-id: john at arbash-meinel.com-20080904024234-bgqpx4oupmqhv5t9
parent: pqm at pqm.ubuntu.com-20080903223056-b108iytb38xkznci
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: jam-integration
timestamp: Wed 2008-09-03 21:42:34 -0500
message:
Properly append the data to the list buffer.
Rather than using [] += 'str', use [].append(str).
It turns out both *work*, but the former adds each character
individually to the list.
-------------- next part --------------
=== modified file 'bzrlib/transport/sftp.py'
--- a/bzrlib/transport/sftp.py 2008-07-18 19:51:08 +0000
+++ b/bzrlib/transport/sftp.py 2008-09-04 02:42:34 +0000
@@ -329,7 +329,7 @@
cur_offset_and_size = offset_stack.next()
for data in fp.readv(requests):
- cur_data += data
+ cur_data.append(data)
cur_data_len += len(data)
if cur_data_len < cur_coalesced.length:
More information about the bazaar-commits
mailing list