Rev 3759: Request from Martin, clearly comment the problem. in http://bzr.arbash-meinel.com/branches/bzr/1.8-dev/block_pyrex_0.9.4.1

[John Arbash Meinel]

At http://bzr.arbash-meinel.com/branches/bzr/1.8-dev/block_pyrex_0.9.4.1

------------------------------------------------------------
revno: 3759
revision-id: john at arbash-meinel.com-20081002153612-nmrpqm17n8bunfrv
parent: john at arbash-meinel.com-20081001221115-loptk3y40vt7e0uv
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: block_pyrex_0.9.4.1
timestamp: Thu 2008-10-02 10:36:12 -0500
message:
  Request from Martin, clearly comment the problem.
  Request from Robert, only blacklist the one known-bad version of pyrex.
-------------- next part --------------
=== modified file 'setup.py'
--- a/setup.py	2008-10-01 22:11:15 +0000
+++ b/setup.py	2008-10-02 15:36:12 +0000
@@ -176,7 +176,6 @@
 else:
     have_pyrex = True
     from Pyrex.Compiler.Version import version as pyrex_version
-    pyrex_version_info = tuple(map(int, pyrex_version.split('.')))
 
 
 class build_ext_if_possible(build_ext):
@@ -239,12 +238,15 @@
     add_pyrex_extension('bzrlib._walkdirs_win32',
                         define_macros=[('WIN32', None)])
 else:
-    if have_pyrex and pyrex_version_info < (0, 9, 6, 0):
+    if have_pyrex and pyrex_version == '0.9.4.1':
         # Pyrex 0.9.4.1 fails to compile this extension correctly
+        # The code it generates re-uses a "local" pointer and
+        # calls "PY_DECREF" after having set it to NULL. (It mixes PY_XDECREF
+        # which is NULL safe with PY_DECREF which is not.)
         print 'Cannot build extension "bzrlib._dirstate_helpers_c" using'
-        print 'your version of pyrex "%s". Please upgrade to a version' % (
+        print 'your version of pyrex "%s". Please upgrade your pyrex' % (
             pyrex_version,)
-        print '>= 0.9.6. For now, the non-compiled (python) version will'
+        print 'install. For now, the non-compiled (python) version will'
         print 'be used instead.'
     else:
         add_pyrex_extension('bzrlib._dirstate_helpers_c')