Rev 37: Clean up references to verbose. in http://bazaar.launchpad.net/%7Ebzr-upload-devs/bzr-upload/trunk

[Vincent Ladeuil]

At http://bazaar.launchpad.net/%7Ebzr-upload-devs/bzr-upload/trunk

------------------------------------------------------------
revno: 37
revision-id: v.ladeuil+lp at free.fr-20080520073644-9tpsdm0qkp7nwa39
parent: argentina at gmail.com-20080520013817-d9ryzj2o8nfb6egs
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: upload
timestamp: Tue 2008-05-20 09:36:44 +0200
message:
  Clean up references to verbose.
  
  * __init__.py:
  (cmd_upload): Clean up references to verbose.
modified:
  __init__.py                    __init__.py-20080307145942-xx1xgifrreovahgz-1
  test_upload.py                 test_upload.py-20080307145942-xx1xgifrreovahgz-2
-------------- next part --------------
=== modified file '__init__.py'
--- a/__init__.py	2008-05-16 21:30:51 +0000
+++ b/__init__.py	2008-05-20 07:36:44 +0000
@@ -64,7 +64,6 @@
     takes_options = [
         'revision',
         'remember',
-        'verbose',
         option.Option('full', 'Upload the full working tree.'),
         option.Option('quiet', 'Do not output what is being done.', 
                        short_name='q'),
@@ -77,7 +76,7 @@
        ]
 
     def run(self, location=None, full=False, revision=None, remember=None,
-            directory=None, verbose=True, quiet=False,
+            directory=None, quiet=False,
             ):
         if directory is None:
             directory = u'.'
@@ -114,7 +113,6 @@
         self.rev_id = rev_id
         self._pending_renames = []
         self._pending_deletions = []
-        self.verbose = verbose
         self.quiet = quiet
 
         if full:
@@ -318,13 +316,15 @@
 def load_tests(basic_tests, module, loader):
     result = loader.suiteClass()
     # add the tests for this module
-    # XXX: this module should define no tests !
+
+    # This module shouldn't define any tests but I don't know how to report
+    # that. I prefer to keep the add Tests to detect unwanted tests and I think
+    # that's sufficient.
     result.addTests(basic_tests)
 
     testmod_names = [
         'test_upload',
         ]
-
     result.addTest(loader.loadTestsFromModuleNames(
             ["%s.%s" % (__name__, tmn) for tmn in testmod_names]))
     return result

=== modified file 'test_upload.py'
--- a/test_upload.py	2008-05-16 20:49:58 +0000
+++ b/test_upload.py	2008-05-20 07:36:44 +0000
@@ -410,6 +410,7 @@
         self.do_upload()
         self.assertUpFileEqual('bar', 'hello')
 
+
 class TestBranchUploadLocations(branch_implementations.TestCaseWithBranch):
 
     def test_get_upload_location_unset(self):