Rev 1257: Use somewhat clearer name for function. in http://people.samba.org/bzr/jelmer/bzr-svn/svn-1.5

Jelmer Vernooij jelmer at samba.org
Thu Jun 26 18:48:54 BST 2008


At http://people.samba.org/bzr/jelmer/bzr-svn/svn-1.5

------------------------------------------------------------
revno: 1257
revision-id: jelmer at samba.org-20080626174854-q07u8th3q39n0f2r
parent: jelmer at samba.org-20080626170850-6n22hyvad5pdzlis
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: svn-1.5
timestamp: Thu 2008-06-26 19:48:54 +0200
message:
  Use somewhat clearer name for function.
modified:
  logwalker.py                   logwalker.py-20060621215743-c13fhfnyzh1xzwh2-1
=== modified file 'logwalker.py'
--- a/logwalker.py	2008-06-26 17:08:50 +0000
+++ b/logwalker.py	2008-06-26 17:48:54 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 2006 Jelmer Vernooij <jelmer at samba.org>
+# Copyright (C) 2006-2008 Jelmer Vernooij <jelmer at samba.org>
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -23,7 +23,8 @@
 from bzrlib.plugins.svn import changes, core
 from bzrlib.plugins.svn.cache import CacheTable
 from bzrlib.plugins.svn.core import SubversionException
-from bzrlib.plugins.svn.errors import ERR_FS_NO_SUCH_REVISION, ERR_FS_NOT_FOUND, ERR_FS_NOT_DIRECTORY
+from bzrlib.plugins.svn.errors import (ERR_FS_NO_SUCH_REVISION, 
+                                       ERR_FS_NOT_FOUND, ERR_FS_NOT_DIRECTORY)
 from bzrlib.plugins.svn.ra import DIRENT_KIND
 from bzrlib.plugins.svn.transport import SvnRaTransport
 
@@ -274,10 +275,7 @@
         path beginning at revision rev, or None if that exact path had not been
         cached since rev.
         """
-        return self.cachedb.execute("""
-            select min(rev) from fetched_rev
-            where path = ? and rev >= ?
-        """, (path, rev)).fetchone()[0]
+        return self.cachedb.execute("select min(rev) from fetched_rev where path = ? and rev >= ?", (path, rev)).fetchone()[0]
 
 
 def struct_revpaths_to_tuples(changed_paths):
@@ -493,7 +491,7 @@
         return revnum
 
     def iter_changes(self, paths, from_revnum, to_revnum=0, limit=0, pb=None):
-        """Return iterator over all the revisions between from_revnum and to_revnum named path or inside path.
+        """Return iterator over selected range of changes.
 
         :param paths:    Paths to report about.
         :param from_revnum:  Start revision.
@@ -708,7 +706,7 @@
         subpath no longer exists."""
         while True:
             try:
-                self._fetch_revisions3(path, from_revnum, to_revnum)
+                self._cache_revisions_range(path, from_revnum, to_revnum)
                 return path
             except SubversionException, (_, num):
                 if num == ERR_FS_NO_SUCH_REVISION:
@@ -721,10 +719,8 @@
                     continue
                 raise
 
-    def _fetch_revisions3(self, path, from_revnum, to_revnum):
-        """Revision fetching level 3: Actually request the log
-        information and store it in the cache table."""
-        
+    def _cache_revisions_range(self, from_revnum, to_revnum, path):
+        """Request the log information and store it in the cache table."""
         if self._transport.has_capability("log-revprops"):
             todo_revprops = None
         else:




More information about the bazaar-commits mailing list