Rev 1307: Add note about SSL certificate breakage. in http://people.samba.org/bzr/jelmer/bzr-svn/0.4

[Jelmer Vernooij]

At http://people.samba.org/bzr/jelmer/bzr-svn/0.4

------------------------------------------------------------
revno: 1307
revision-id: jelmer at samba.org-20080623030911-yaum12tcthoe0hka
parent: jelmer at samba.org-20080623025649-reunkm3f4v0uiqr0
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: 0.4
timestamp: Mon 2008-06-23 05:09:11 +0200
message:
  Add note about SSL certificate breakage.
modified:
  NEWS                           news-20061231030336-h9fhq245ie0de8bs-1
  auth.py                        auth.py-20071209174622-w8d42k6nm5yhxvi8-1
=== modified file 'NEWS'
--- a/NEWS	2008-06-22 22:23:53 +0000
+++ b/NEWS	2008-06-23 03:09:11 +0000
@@ -14,6 +14,8 @@
 
      * KeyboardInterrupts are now no longer swallowed.  (#242217)
 
+     * Crash bug trying to access sites that use self-signed certificates. (#238529)
+
    * Now uses absolute imports and no longer adds plugin directory to the system path.
 
   BUG FIXES

=== modified file 'auth.py'
--- a/auth.py	2008-06-22 16:21:31 +0000
+++ b/auth.py	2008-06-23 03:09:11 +0000
@@ -16,6 +16,7 @@
 """Authentication token retrieval."""
 
 from bzrlib.config import AuthenticationConfig
+from bzrlib.trace import mutter
 from bzrlib.ui import ui_factory
 
 from bzrlib.plugins.svn import ra
@@ -75,6 +76,7 @@
         :param cert_info: Certificate information
         :param may_save: Whether this information may be stored.
         """
+        mutter("Verifying SSL server: %s", realm)
         credentials = self.get_credentials(self.scheme, host=self.host)
         if (credentials is not None and 
             credentials.has_key("verify_certificates") and 
@@ -118,6 +120,7 @@
                 self.get_svn_simple_prompt_provider(1),
                 self.get_svn_ssl_server_trust_prompt_provider()]
 
+
 def get_ssl_client_cert_pw(realm, may_save):
     """Simple SSL client certificate password prompter.
 
@@ -165,9 +168,9 @@
 
     # Specify Subversion providers first, because they use file data
     # rather than prompting the user.
-    providers = get_stock_svn_providers()
-    providers += auth_config.get_svn_auth_providers()
+    providers = auth_config.get_svn_auth_providers()
     providers += [get_ssl_client_cert_pw_provider(1)]
+    providers += get_stock_svn_providers()
 
     auth_baton = ra.Auth(providers)
     if creds is not None: