Rev 3530: Unregister defunct HPSS verbs. Fixes incompatibility with clients <= in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 3530
revision-id:pqm at pqm.ubuntu.com-20080707230506-82h5w03vc72dyf1a
parent: pqm at pqm.ubuntu.com-20080707191804-ywaxy9kcyvv8yhj2
parent: andrew.bennetts at canonical.com-20080707054540-ud0dgt662j5t198w
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Tue 2008-07-08 00:05:06 +0100
message:
  Unregister defunct HPSS verbs. Fixes incompatibility with clients <=
  	1.5. (Andrew Bennetts)
modified:
  bzrlib/smart/request.py        request.py-20061108095550-gunadhxmzkdjfeek-1
  bzrlib/tests/test_smart.py     test_smart.py-20061122024551-ol0l0o0oofsu9b3t-2
    ------------------------------------------------------------
    revno: 3526.3.1
    revision-id:andrew.bennetts at canonical.com-20080707054540-ud0dgt662j5t198w
    parent: pqm at pqm.ubuntu.com-20080704171330-ieh195xj7su2k2xq
    committer: Andrew Bennetts <andrew.bennetts at canonical.com>
    branch nick: hpss-1.5-compat
    timestamp: Mon 2008-07-07 15:45:40 +1000
    message:
      Remove registrations of defunct HPSS verbs.
    modified:
      bzrlib/smart/request.py        request.py-20061108095550-gunadhxmzkdjfeek-1
      bzrlib/tests/test_smart.py     test_smart.py-20061122024551-ol0l0o0oofsu9b3t-2
=== modified file 'bzrlib/smart/request.py'
--- a/bzrlib/smart/request.py	2008-06-19 02:51:12 +0000
+++ b/bzrlib/smart/request.py	2008-07-07 05:45:40 +0000
@@ -431,14 +431,6 @@
                                'bzrlib.smart.repository',
                                'SmartServerRepositoryGetParentMap')
 request_handlers.register_lazy(
-    'Repository.stream_knit_data_for_revisions',
-    'bzrlib.smart.repository',
-    'SmartServerRepositoryStreamKnitDataForRevisions')
-request_handlers.register_lazy(
-    'Repository.stream_revisions_chunked',
-    'bzrlib.smart.repository',
-    'SmartServerRepositoryStreamRevisionsChunked')
-request_handlers.register_lazy(
     'Repository.get_revision_graph', 'bzrlib.smart.repository', 'SmartServerRepositoryGetRevisionGraph')
 request_handlers.register_lazy(
     'Repository.has_revision', 'bzrlib.smart.repository', 'SmartServerRequestHasRevision')

=== modified file 'bzrlib/tests/test_smart.py'
--- a/bzrlib/tests/test_smart.py	2008-06-25 22:27:57 +0000
+++ b/bzrlib/tests/test_smart.py	2008-07-07 05:45:40 +0000
@@ -1011,6 +1011,13 @@
 class TestHandlers(tests.TestCase):
     """Tests for the request.request_handlers object."""
 
+    def test_all_registrations_exist(self):
+        """All registered request_handlers can be found."""
+        # If there's a typo in a register_lazy call, this loop will fail with
+        # an AttributeError.
+        for key, item in smart.request.request_handlers.iteritems():
+            pass
+
     def test_registered_methods(self):
         """Test that known methods are registered to the correct object."""
         self.assertEqual(