Rev 840: Make sure NotSvnBranchPath and InvalidSvnBranchPath accept non-ascii in file:///data/jelmer/bzr-svn/0.4/

Jelmer Vernooij jelmer at samba.org
Fri Jan 18 04:05:55 GMT 2008


At file:///data/jelmer/bzr-svn/0.4/

------------------------------------------------------------
revno: 840
revision-id:jelmer at samba.org-20080117234644-k5quqeqg16qolj4v
parent: jelmer at samba.org-20080117234221-gfh2qw3y5h8xv087
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: 0.4
timestamp: Fri 2008-01-18 00:46:44 +0100
message:
  Make sure NotSvnBranchPath and InvalidSvnBranchPath accept non-ascii 
  branch paths.
modified:
  errors.py                      errors.py-20061226172623-w1sbj8ynpo0eojqp-1
  tests/test_errors.py           test_errors.py-20070129114605-ban03f32t6ja14ez-1
=== modified file 'errors.py'
--- a/errors.py	2008-01-17 23:42:21 +0000
+++ b/errors.py	2008-01-17 23:46:44 +0000
@@ -32,7 +32,7 @@
 See 'bzr help svn-branching-schemes' for details."""
 
     def __init__(self, branch_path, scheme=None):
-        NotBranchError.__init__(self, branch_path)
+        NotBranchError.__init__(self, urllib.quote(branch_path))
         self.scheme = scheme
 
 

=== modified file 'tests/test_errors.py'
--- a/tests/test_errors.py	2007-11-01 01:33:04 +0000
+++ b/tests/test_errors.py	2008-01-17 23:46:44 +0000
@@ -20,6 +20,7 @@
 from bzrlib.tests import TestCase
 
 from errors import (convert_svn_error, convert_error, InvalidPropertyValue, 
+                    InvalidSvnBranchPath, NotSvnBranchPath, 
                     SVN_ERR_UNKNOWN_HOSTNAME)
 
 import svn.core
@@ -78,3 +79,9 @@
         self.assertEqual(
           "Invalid property value for Subversion property svn:foobar: corrupt", 
           str(error))
+
+    def test_invalidsvnbranchpath_nonascii(self):
+        InvalidSvnBranchPath('\xc3\xb6', None)
+
+    def test_notsvnbranchpath_nonascii(self):
+        NotSvnBranchPath('\xc3\xb6', None)




More information about the bazaar-commits mailing list