Rev 3804: Add a TODO about avoiding all of the get_record_stream calls. in http://bazaar.launchpad.net/%7Ebzr/bzr/brisbane-core

John Arbash Meinel john at arbash-meinel.com
Fri Dec 12 21:51:05 GMT 2008


At http://bazaar.launchpad.net/%7Ebzr/bzr/brisbane-core

------------------------------------------------------------
revno: 3804
revision-id: john at arbash-meinel.com-20081212215041-k67v6pkxb97y1ccy
parent: john at arbash-meinel.com-20081212214614-mszc023ur9lwi9r4
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: brisbane-core
timestamp: Fri 2008-12-12 15:50:41 -0600
message:
  Add a TODO about avoiding all of the get_record_stream calls.
-------------- next part --------------
=== modified file 'bzrlib/chk_map.py'
--- a/bzrlib/chk_map.py	2008-12-12 21:46:14 +0000
+++ b/bzrlib/chk_map.py	2008-12-12 21:50:41 +0000
@@ -1130,6 +1130,10 @@
     """
     # TODO: consider that it may be more memory efficient to use the 20-byte
     #       sha1 string, rather than tuples of hexidecimal sha1 strings.
+    # TODO: Try to factor out a lot of the get_record_stream() calls into a
+    #       helper function similar to _read_bytes. This function should be
+    #       able to use nodes from the _page_cache as well as actually
+    #       requesting bytes from the store.
 
     # A way to adapt from the compressed texts back into fulltexts
     # In a way, this seems like a layering inversion to have CHKMap know the



More information about the bazaar-commits mailing list