Rev 3885: Fixed as per Robert's review. in lp:~vila/bzr/303959-redirection

Vincent Ladeuil v.ladeuil+lp at free.fr
Fri Dec 12 12:25:50 GMT 2008


At lp:~vila/bzr/303959-redirection

------------------------------------------------------------
revno: 3885
revision-id: v.ladeuil+lp at free.fr-20081212122548-cd4vs5pp3k2i9e25
parent: v.ladeuil+lp at free.fr-20081204171246-p28b3u0e2alz53iv
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: 303959-redirection
timestamp: Fri 2008-12-12 13:25:48 +0100
message:
  Fixed as per Robert's review.
  
  * bzrlib/transport/http/__init__.py:
  (HttpTransportBase._redirected_to): Better comment.
-------------- next part --------------
=== modified file 'bzrlib/transport/http/__init__.py'
--- a/bzrlib/transport/http/__init__.py	2008-12-04 17:12:46 +0000
+++ b/bzrlib/transport/http/__init__.py	2008-12-12 12:25:48 +0000
@@ -550,7 +550,11 @@
         # redirected, we end up with the same url
         base_path = path[:-len(relpath)]
         if scheme in ('http', 'https'):
-            # Same protocol (i.e. http[s])
+            # Same protocol family (i.e. http[s]), we will preserve the same
+            # http client implementation when a redirection occurs from one to
+            # the other (otherwise users may be surprised that bzr switches
+            # from one implementation to the other, and devs may suffer
+            # debugging it).
             if (scheme == self._unqualified_scheme
                 and host == self._host
                 and port == self._port



More information about the bazaar-commits mailing list