Rev 3895: We don't need to inline get_cached until we've had the miss. in http://bzr.arbash-meinel.com/branches/bzr/1.11/xml_cache

John Arbash Meinel john at arbash-meinel.com
Wed Dec 10 23:05:45 GMT 2008


At http://bzr.arbash-meinel.com/branches/bzr/1.11/xml_cache

------------------------------------------------------------
revno: 3895
revision-id: john at arbash-meinel.com-20081210230521-t1t4d6yfh8kt6ft8
parent: john at arbash-meinel.com-20081210223943-aqedq91tf7e6tecs
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: xml_cache
timestamp: Wed 2008-12-10 17:05:21 -0600
message:
  We don't need to inline get_cached until we've had the miss.
-------------- next part --------------
=== modified file 'bzrlib/xml8.py'
--- a/bzrlib/xml8.py	2008-12-10 22:39:43 +0000
+++ b/bzrlib/xml8.py	2008-12-10 23:05:21 +0000
@@ -385,9 +385,7 @@
         return inv
 
     def _unpack_entry(self, elt):
-        get_cached = _get_utf8_or_ascii
         elt_get = elt.get
-
         file_id = elt_get('file_id')
         revision = elt_get('revision')
         # Check and see if we have already unpacked this exact entry
@@ -438,6 +436,8 @@
         if not InventoryEntry.versionable_kind(kind):
             raise AssertionError('unsupported entry kind %s' % kind)
 
+        get_cached = _get_utf8_or_ascii
+
         file_id = get_cached(file_id)
         if revision is not None:
             revision = get_cached(revision)



More information about the bazaar-commits mailing list