Rev 59: Revert the group size shrinking, measurement shows it does not pay off well. in http://people.ubuntu.com/~robertc/baz2.0/plugins/search/trunk

Robert Collins robertc at robertcollins.net
Tue Dec 2 19:08:46 GMT 2008


At http://people.ubuntu.com/~robertc/baz2.0/plugins/search/trunk

------------------------------------------------------------
revno: 59
revision-id: robertc at robertcollins.net-20081202190844-y4bl3qymkndab5m0
parent: robertc at robertcollins.net-20081116230104-6zytzth3br38bg63
committer: Robert Collins <robertc at robertcollins.net>
branch nick: trunk
timestamp: Wed 2008-12-03 06:08:44 +1100
message:
  Revert the group size shrinking, measurement shows it does not pay off well.
modified:
  index.py                       index.py-20080608055509-hnimeek7q8tctkqf-2
=== modified file 'index.py'
--- a/index.py	2008-11-16 23:01:04 +0000
+++ b/index.py	2008-12-02 19:08:44 +0000
@@ -337,7 +337,10 @@
         for pos, revid in enumerate(order):
             order_dict[revid] = pos
         # 5000 uses 1GB on a mysql tree.
-        group_size = 50
+        # Testing shows 1500 or so is a sweet spot for bzr, 2500 for python - ideally this wouldn't matter.
+        # Interesting only 2 times reduction in memory was observed every down
+        # at a group of 50, though it does slowly grow as it increases.
+        group_size = 2000
         groups = len(order) / group_size + 1
         for offset in range(groups):
             outer_bar.update("Indexing...", offset, groups)




More information about the bazaar-commits mailing list