Rev 106: Test that getting an unknown revision fails. in http://people.samba.org/bzr/jelmer/bzr-git/trunk

[Jelmer Vernooij]

At http://people.samba.org/bzr/jelmer/bzr-git/trunk

------------------------------------------------------------
revno: 106
revision-id: jelmer at samba.org-20080830183551-gz2usxl83d5hmt29
parent: jelmer at samba.org-20080830172205-lcix3iotfzk2agej
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: trunk
timestamp: Sat 2008-08-30 20:35:51 +0200
message:
  Test that getting an unknown revision fails.
modified:
  repository.py                  git_repository.py-20071108234408-ygidvy5hviixghsd-2
  tests/test_repository.py       test_git_repository.-20071108234408-ygidvy5hviixghsd-5
=== modified file 'repository.py'
--- a/repository.py	2008-08-30 17:22:05 +0000
+++ b/repository.py	2008-08-30 18:35:51 +0000
@@ -88,7 +88,7 @@
             max_count = 1000
             cms = None
             while cms != []:
-                cms = self._git.commits(self.lookup_git_revid(revision_id, self), max_count=max_count, skip=skip)
+                cms = self._git.commits(self.lookup_git_revid(revision_id, default_mapping), max_count=max_count, skip=skip)
                 skip += max_count
                 ret += [default_mapping.revision_id_foreign_to_bzr(cm.id) for cm in cms]
         return [None] + ret

=== modified file 'tests/test_repository.py'
--- a/tests/test_repository.py	2008-08-29 15:58:12 +0000
+++ b/tests/test_repository.py	2008-08-30 18:35:51 +0000
@@ -67,6 +67,12 @@
         rev = repo.get_revision(revid)
         self.assertIsInstance(rev, revision.Revision)
 
+    def test_get_revision_unknown(self):
+        tests.run_git('init')
+
+        repo = Repository.open('.')
+        self.assertRaises(errors.NoSuchRevision, repo.get_revision, "bla")
+
     def simple_commit(self):
         # Create a git repository with some interesting files in a revision.
         tests.run_git('init')