Rev 3669: Update a code comment. in http://bzr.arbash-meinel.com/branches/bzr/1.7-dev/graph_index_autobuffer

John Arbash Meinel john at arbash-meinel.com
Fri Aug 29 19:58:49 BST 2008


At http://bzr.arbash-meinel.com/branches/bzr/1.7-dev/graph_index_autobuffer

------------------------------------------------------------
revno: 3669
revision-id: john at arbash-meinel.com-20080829185848-svqlofrr394rp9x9
parent: john at arbash-meinel.com-20080829173847-n3h7gwv6hep9glbn
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: graph_index_autobuffer
timestamp: Fri 2008-08-29 13:58:48 -0500
message:
  Update a code comment.
-------------- next part --------------
=== modified file 'bzrlib/index.py'
--- a/bzrlib/index.py	2008-08-29 17:38:47 +0000
+++ b/bzrlib/index.py	2008-08-29 18:58:48 +0000
@@ -999,14 +999,9 @@
             for offset, data in readv_data:
                 self._bytes_read += len(data)
                 if offset == 0 and len(data) == self._size:
-                    # We 'accidentally' read the whole range, go straight into
-                    # '_buffer_all'. This could happen because the transport
-                    # upcast our readv request, or because we actually need
-                    # most of the file.
-                    # TODO: This could have been triggered by
-                    # _lookup_keys_via_location, so we can't just return
-                    # unconditionally here, we need to still fill out the
-                    # _bisect_nodes list.
+                    # We read the whole range, most likely because the
+                    # Transport upcast our readv ranges into one long request
+                    # for enough total data to grab the whole index.
                     self._buffer_all(StringIO(data))
                     return
                 if self._bisect_nodes is None:



More information about the bazaar-commits mailing list