Rev 3618: We don't have to fetch in topological order, as long as we fix all of the delta logic pieces. in http://bzr.arbash-meinel.com/branches/bzr/1.6-dev/fetch_regression_256757

John Arbash Meinel john at arbash-meinel.com
Mon Aug 18 20:13:54 BST 2008


At http://bzr.arbash-meinel.com/branches/bzr/1.6-dev/fetch_regression_256757

------------------------------------------------------------
revno: 3618
revision-id: john at arbash-meinel.com-20080818191351-de63gybx2jaco2yo
parent: john at arbash-meinel.com-20080818190432-gkn0umj08xln8owu
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: fetch_regression_256757
timestamp: Mon 2008-08-18 14:13:51 -0500
message:
  We don't have to fetch in topological order, as long as we fix all of the delta logic pieces.
modified:
  bzrlib/repofmt/pack_repo.py    pack_repo.py-20070813041115-gjv5ma7ktfqwsjgn-1
  bzrlib/tests/test_pack_repository.py test_pack_repository-20080801043947-eaw0e6h2gu75kwmy-1
-------------- next part --------------
=== modified file 'bzrlib/repofmt/pack_repo.py'
--- a/bzrlib/repofmt/pack_repo.py	2008-08-18 18:55:37 +0000
+++ b/bzrlib/repofmt/pack_repo.py	2008-08-18 19:13:51 +0000
@@ -1719,7 +1719,7 @@
         self._reconcile_does_inventory_gc = True
         self._reconcile_fixes_text_parents = True
         self._reconcile_backsup_inventory = False
-        self._fetch_order = 'topological'
+        self._fetch_order = 'unsorted'
 
     def _warn_if_deprecated(self):
         # This class isn't deprecated

=== modified file 'bzrlib/tests/test_pack_repository.py'
--- a/bzrlib/tests/test_pack_repository.py	2008-08-18 19:04:32 +0000
+++ b/bzrlib/tests/test_pack_repository.py	2008-08-18 19:13:51 +0000
@@ -62,14 +62,10 @@
         return bzrdir.format_registry.make_bzrdir(self.format_name)
 
     def test_attribute__fetch_order(self):
-        """Packs do not need ordered data retrieval.
-
-        Except experience shows they need ordered data insertion, so for now,
-        they request topological.
-        """
+        """Packs do not need ordered data retrieval."""
         format = self.get_format()
         repo = self.make_repository('.', format=format)
-        self.assertEqual('topological', repo._fetch_order)
+        self.assertEqual('unsorted', repo._fetch_order)
 
     def test_attribute__fetch_uses_deltas(self):
         """Packs reuse deltas."""



More information about the bazaar-commits mailing list