Rev 3395: We don't actually use common_ancestors_unique, so get rid of it. in http://bzr.arbash-meinel.com/branches/bzr/1.4-dev/find_differences

[John Arbash Meinel]

At http://bzr.arbash-meinel.com/branches/bzr/1.4-dev/find_differences

------------------------------------------------------------
revno: 3395
revision-id: john at arbash-meinel.com-20080423221521-zya0eumw6tmo2ii6
parent: john at arbash-meinel.com-20080423221309-etwdaic43iytt8n1
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: find_differences
timestamp: Wed 2008-04-23 17:15:21 -0500
message:
  We don't actually use common_ancestors_unique, so get rid of it.
  
  It was meant to avoid redoing work, but pretty much had 0 hit rate.
modified:
  bzrlib/graph.py                graph_walker.py-20070525030359-y852guab65d4wtn0-1
-------------- next part --------------
=== modified file 'bzrlib/graph.py'
--- a/bzrlib/graph.py	2008-04-23 22:13:09 +0000
+++ b/bzrlib/graph.py	2008-04-23 22:15:21 +0000
@@ -541,7 +541,6 @@
         # possible todo: aggregate the common searchers into a single common
         #   searcher, just make sure that we include the nodes into the .seen
         #   properties of the original searchers
-        common_ancestors_unique = set()
 
         ancestor_all_unique = None
         for searcher in unique_searchers:
@@ -560,10 +559,6 @@
                 newly_seen_unique.update(searcher.step())
             new_common_unique = set()
             for revision in newly_seen_unique:
-                if revision in common_ancestors_unique:
-                    # It is already in common_ancestors_unique, so we don't
-                    # need to search it again.
-                    continue
                 for searcher in unique_searchers:
                     if revision not in searcher.seen:
                         break
@@ -613,7 +608,6 @@
                     searcher.start_searching(new_common_unique)
                 for searcher in common_searchers:
                     searcher.stop_searching_any(new_common_unique)
-                common_ancestors_unique.update(new_common_unique)
                 ancestor_all_unique.update(new_common_unique)
             for searcher in common_searchers:
                 if searcher._next_query: