Rev 3370: (jam) Remove annoying mutter(), bug #213771 in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

Canonical.com Patch Queue Manager pqm at pqm.ubuntu.com
Wed Apr 16 18:28:17 BST 2008


At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 3370
revision-id:pqm at pqm.ubuntu.com-20080416172809-mq3p3rm6q3vefyyz
parent: pqm at pqm.ubuntu.com-20080416060444-1mgq4chv82tgm2sc
parent: john at arbash-meinel.com-20080416144453-ygnhktfu94sposlw
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Wed 2008-04-16 18:28:09 +0100
message:
  (jam) Remove annoying mutter(), bug #213771
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/progress.py             progress.py-20050610070202-df9faaab791964c0
    ------------------------------------------------------------
    revno: 3369.1.1
    revision-id:john at arbash-meinel.com-20080416144453-ygnhktfu94sposlw
    parent: pqm at pqm.ubuntu.com-20080416060444-1mgq4chv82tgm2sc
    committer: John Arbash Meinel <john at arbash-meinel.com>
    branch nick: bug_213771
    timestamp: Wed 2008-04-16 09:44:53 -0500
    message:
      Fix bug #213771, just remove the unnecessary mutter() call.
    modified:
      NEWS                           NEWS-20050323055033-4e00b5db738777ff
      bzrlib/progress.py             progress.py-20050610070202-df9faaab791964c0
=== modified file 'NEWS'
--- a/NEWS	2008-04-14 22:39:51 +0000
+++ b/NEWS	2008-04-16 14:44:53 +0000
@@ -23,6 +23,9 @@
 
   BUGFIXES:
 
+    * Avoid muttering every time a child update does not cause a progress bar
+      update. (John Arbash Meinel, #213771)
+
     * Severe performance degradation in fetching from knit repositories to
       packs due to parsing the entire revisions.kndx on every graph walk
       iteration fixed by using the Repository.get_graph API. (Robert Collins)

=== modified file 'bzrlib/progress.py'
--- a/bzrlib/progress.py	2008-02-13 03:30:01 +0000
+++ b/bzrlib/progress.py	2008-04-16 14:44:53 +0000
@@ -325,8 +325,6 @@
                 pass
             elif self.last_cnt + child_fraction <= self.last_total:
                 self.child_fraction = child_fraction
-            else:
-                mutter('not updating child fraction')
         if self.last_msg is None:
             self.last_msg = ''
         self.tick()




More information about the bazaar-commits mailing list