Rev 3360: Fix trivial bug in in file:///home/pqm/archives/thelove/bzr/%2Btrunk/
Canonical.com Patch Queue Manager
pqm at pqm.ubuntu.com
Fri Apr 11 03:32:31 BST 2008
At file:///home/pqm/archives/thelove/bzr/%2Btrunk/
------------------------------------------------------------
revno: 3360
revision-id:pqm at pqm.ubuntu.com-20080411023221-tiv070pmkmf5q726
parent: pqm at pqm.ubuntu.com-20080410210348-pb55271fnuv0huk0
parent: luntain at organon2ubuntu-20080410184045-em1dlve94n7zh66q
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Fri 2008-04-11 03:32:21 +0100
message:
Fix trivial bug in
_test_client_read_response_tuple_raises_UnknownSmartMethod test
helper. (Kamil Dworakowski)
modified:
bzrlib/tests/test_smart_transport.py test_ssh_transport.py-20060608202016-c25gvf1ob7ypbus6-2
------------------------------------------------------------
revno: 3356.1.1
revision-id:luntain at organon2ubuntu-20080410184045-em1dlve94n7zh66q
parent: pqm at pqm.ubuntu.com-20080410142221-5peelooccmd1uc8g
committer: Kamil Dworakowski <luntain at organon2ubuntu>
branch nick: bzr_fix
timestamp: Thu 2008-04-10 19:40:45 +0100
message:
fix a test to check for the right thing
A local variable shadows the parameter of the
_test_client_read_response_tuple_raises_UnknownSmartMethod method, which
effectively renders one of the tests not checking the right thing. The fix
is to delete the variable.
modified:
bzrlib/tests/test_smart_transport.py test_ssh_transport.py-20060608202016-c25gvf1ob7ypbus6-2
=== modified file 'bzrlib/tests/test_smart_transport.py'
--- a/bzrlib/tests/test_smart_transport.py 2008-04-10 06:55:05 +0000
+++ b/bzrlib/tests/test_smart_transport.py 2008-04-10 18:40:45 +0000
@@ -1668,8 +1668,6 @@
def _test_client_read_response_tuple_raises_UnknownSmartMethod(self,
server_bytes):
- server_bytes = (
- "error\x01Generic bzr smart protocol error: bad request 'foo'\n")
input = StringIO(server_bytes)
output = StringIO()
client_medium = medium.SmartSimplePipesClientMedium(input, output)
More information about the bazaar-commits
mailing list