Rev 3331: Final review feedback. in http://people.ubuntu.com/~robertc/baz2.0/versioned_files

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/versioned_files

------------------------------------------------------------
revno: 3331
revision-id: robertc at robertcollins.net-20080409213934-hf17drb3br1yyspz
parent: robertc at robertcollins.net-20080409201346-2m5dpim3cowzwacs
committer: Robert Collins <robertc at robertcollins.net>
branch nick: api-cleanup
timestamp: Thu 2008-04-10 07:39:34 +1000
message:
  Final review feedback.
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/knit.py                 knit.py-20051212171256-f056ac8f0fbe1bd9
=== modified file 'NEWS'
--- a/NEWS	2008-04-09 20:13:46 +0000
+++ b/NEWS	2008-04-09 21:39:34 +0000
@@ -121,7 +121,8 @@
 
     * ``KnitVersionedFile`` no longer accepts an ``access_mode`` parameter, and
       now requires the ``index`` and ``access_method`` parameters to be
-      supplied. (Robert Collins)
+      supplied. A compatible shim has been kept in the new function
+      ``knit.make_file_knit``. (Robert Collins)
 
     * Log formatters must now provide log_revision instead of show and
       show_merge_revno methods. The latter had been deprecated since the 0.17
@@ -186,7 +187,7 @@
       get_weave_or_empty method no longer guarantees errors on a missing weave
       in a readonly transaction, and no longer caches versioned file instances
       which reduces memory pressure (but requires more careful management by
-      callers to preserve performance.  (Robert Collins)
+      callers to preserve performance). (Robert Collins)
 
   TESTING:
 

=== modified file 'bzrlib/knit.py'
--- a/bzrlib/knit.py	2008-04-09 00:34:54 +0000
+++ b/bzrlib/knit.py	2008-04-09 21:39:34 +0000
@@ -559,7 +559,7 @@
         self._max_delta_chain = 200
 
         if None in (access_method, index):
-            raise NotImplementedError, "No default access_method or index any more"
+            raise ValueError("No default access_method or index any more")
         self._index = index
         _access = access_method
         if create and not len(self) and not delay_create: