Rev 2820: Review feedback. in http://people.ubuntu.com/~robertc/baz2.0/pack-support

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/pack-support

------------------------------------------------------------
revno: 2820
revision-id: robertc at robertcollins.net-20070923191242-zhem9hyu4s3iv0is
parent: robertc at robertcollins.net-20070914021941-wjd6iu3rnqarh07q
committer: Robert Collins <robertc at robertcollins.net>
branch nick: pack-support
timestamp: Mon 2007-09-24 05:12:42 +1000
message:
  Review feedback.
modified:
  bzrlib/tests/branch_implementations/test_branch.py testbranch.py-20050711070244-121d632bc37d7253
  bzrlib/tests/test_repository.py test_repository.py-20060131075918-65c555b881612f4d
=== modified file 'bzrlib/tests/branch_implementations/test_branch.py'
--- a/bzrlib/tests/branch_implementations/test_branch.py	2007-09-14 02:19:41 +0000
+++ b/bzrlib/tests/branch_implementations/test_branch.py	2007-09-23 19:12:42 +0000
@@ -278,7 +278,7 @@
         repo = wt.branch.repository
         repo.lock_write()
         repo.start_write_group()
-        repo.sign_revision('A', bzrlib.gpg.LoopbackGPGStrategy(None))
+        repo.sign_revision('A', gpg.LoopbackGPGStrategy(None))
         repo.commit_write_group()
         repo.unlock()
         #FIXME: clone should work to urls,

=== modified file 'bzrlib/tests/test_repository.py'
--- a/bzrlib/tests/test_repository.py	2007-08-30 08:27:29 +0000
+++ b/bzrlib/tests/test_repository.py	2007-09-23 19:12:42 +0000
@@ -160,6 +160,15 @@
                           control.transport.get,
                           'ancestry.weave')
 
+    def test_exposed_versioned_files_are_marked_dirty(self):
+        control = bzrdir.BzrDirFormat6().initialize(self.get_url())
+        repo = weaverepo.RepositoryFormat6().initialize(control)
+        repo.lock_write()
+        inv = repo.get_inventory_weave()
+        repo.unlock()
+        self.assertRaises(errors.OutSideTransaction,
+            inv.add_lines, 'foo', [], [])
+
 
 class TestFormat7(TestCaseWithTransport):
     
@@ -264,6 +273,15 @@
                              'W\n',
                              t.get('inventory.weave').read())
 
+    def test_exposed_versioned_files_are_marked_dirty(self):
+        control = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
+        repo = weaverepo.RepositoryFormat7().initialize(control)
+        repo.lock_write()
+        inv = repo.get_inventory_weave()
+        repo.unlock()
+        self.assertRaises(errors.OutSideTransaction,
+            inv.add_lines, 'foo', [], [])
+
 
 class TestFormatKnit1(TestCaseWithTransport):
     
@@ -342,6 +360,16 @@
         self.assertTrue(S_ISDIR(t.stat('knits').st_mode))
         self.check_knits(t)
 
+    def test_exposed_versioned_files_are_marked_dirty(self):
+        format = bzrdir.BzrDirMetaFormat1()
+        format.repository_format = knitrepo.RepositoryFormatKnit1()
+        repo = self.make_repository('.', format=format)
+        repo.lock_write()
+        inv = repo.get_inventory_weave()
+        repo.unlock()
+        self.assertRaises(errors.OutSideTransaction,
+            inv.add_lines, 'foo', [], [])
+
 
 class KnitRepositoryStreamTests(test_knit.KnitTests):
     """Tests for knitrepo._get_stream_as_bytes."""
@@ -417,7 +445,7 @@
 
     This is for use during testing where we use DummyRepository as repositories
     so that none of the default regsitered inter-repository classes will
-    match.
+    MATCH.
     """
 
     @staticmethod
@@ -559,3 +587,12 @@
         revision_tree = tree.branch.repository.revision_tree('dull2')
         self.assertEqual('dull', revision_tree.inventory.root.revision)
 
+    def test_exposed_versioned_files_are_marked_dirty(self):
+        format = bzrdir.BzrDirMetaFormat1()
+        format.repository_format = knitrepo.RepositoryFormatKnit3()
+        repo = self.make_repository('.', format=format)
+        repo.lock_write()
+        inv = repo.get_inventory_weave()
+        repo.unlock()
+        self.assertRaises(errors.OutSideTransaction,
+            inv.add_lines, 'foo', [], [])