Rev 29: Empty strings should not count as email addresses for should_send. in http://bazaar.launchpad.net/~bzr/bzr-email/trunk

[Robert Collins]

At http://bazaar.launchpad.net/~bzr/bzr-email/trunk

------------------------------------------------------------
revno: 29
revision-id: robertc at robertcollins.net-20070919213805-jo3n2ljmdhg3mcwv
parent: robertc at robertcollins.net-20070708065727-a4cswbc1w7aw215i
committer: Robert Collins <robertc at robertcollins.net>
branch nick: trunk
timestamp: Thu 2007-09-20 07:38:05 +1000
message:
  Empty strings should not count as email addresses for should_send.
modified:
  emailer.py                     emailer.py-20070123220937-ec5y2n2oeoa0p4ue-1
=== modified file 'emailer.py'
--- a/emailer.py	2007-02-17 18:09:12 +0000
+++ b/emailer.py	2007-09-19 21:38:05 +0000
@@ -222,7 +222,7 @@
                                             self.diff_filename())
 
     def should_send(self):
-        return self.to() is not None and self.from_address() is not None
+        return self.to() and self.from_address()
 
     def send_maybe(self):
         if self.should_send():