Rev 2832: Fix #140614 selftest _http_start noise by respecting semaphores. in file:///v/home/vila/src/bugs/140614/

[Vincent Ladeuil]

At file:///v/home/vila/src/bugs/140614/

------------------------------------------------------------
revno: 2832
revision-id: v.ladeuil+lp at free.fr-20070918155554-ufhp8sywu3jb5cc3
parent: pqm at pqm.ubuntu.com-20070918045733-es6jch43pxvogvhj
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: 140614
timestamp: Tue 2007-09-18 17:55:54 +0200
message:
  Fix #140614 selftest _http_start noise by respecting semaphores.
  
  * HttpServer.py:
  (HttpServer._http_start): Set the timeout *before* releasing the
  semaphore or it may fail semi-randomly.
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/HttpServer.py     httpserver.py-20061012142527-m1yxdj1xazsf8d7s-1
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2007-09-18 01:29:59 +0000
+++ b/NEWS	2007-09-18 15:55:54 +0000
@@ -47,6 +47,9 @@
 
    * Fix commit ordering in corner case (Aaron Bentley, #94975)
 
+   * Fix selftest semi-random noise during http related tests.
+     (Vincent Ladeuil, #140614)
+
   API BREAKS:
 
    * The ``VersionedFile`` interface now allows content checks to be bypassed

=== modified file 'bzrlib/tests/HttpServer.py'
--- a/bzrlib/tests/HttpServer.py	2007-09-17 15:48:23 +0000
+++ b/bzrlib/tests/HttpServer.py	2007-09-18 15:55:54 +0000
@@ -326,8 +326,8 @@
         self._http_base_url = '%s://%s:%s/' % (self._url_protocol,
                                                self.host,
                                                self.port)
-        self._http_starting.release()
         httpd.socket.settimeout(0.1)
+        self._http_starting.release()
 
         while self._http_running:
             try: