Rev 2815: Renamed install_hooks to start_logging_connections (as per Martin suggestion). in file:///v/home/vila/src/experimental/bzr.it/

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Sep 11 15:47:04 BST 2007


At file:///v/home/vila/src/experimental/bzr.it/

------------------------------------------------------------
revno: 2815
revision-id: v.ladeuil+lp at free.fr-20070911144702-wtrbcqhvlg9zwttk
parent: pqm at pqm.ubuntu.com-20070911055622-a3060rj7l0iy38l2
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: bzr.it
timestamp: Tue 2007-09-11 16:47:02 +0200
message:
  Renamed install_hooks to start_logging_connections (as per Martin suggestion).
  
  * bzrlib/tests/transport_util.py:
  (TestCaseWithConnectionHookedTransport.start_logging_connections):
  Renamed from install_hooks.
  
  
  * bzrlib/tests/commands/*:
  install_hooks calls updated.
modified:
  bzrlib/tests/commands/test_branch.py test_branch.py-20070520173042-ou3a796w3xn1y8ps-1
  bzrlib/tests/commands/test_cat.py test_cat.py-20070525170351-vg2apsfb5j413913-1
  bzrlib/tests/commands/test_checkout.py test_checkout.py-20070525151718-vm7ligd5px5dtmda-1
  bzrlib/tests/commands/test_init.py test_init.py-20070514074921-audbcdd8o56dpame-1
  bzrlib/tests/commands/test_init_repository.py test_init_repository-20070525163812-87xw0678ky573l27-1
  bzrlib/tests/commands/test_merge.py test_merge.py-20070525163813-v8yfs5wu77hjsx0o-1
  bzrlib/tests/commands/test_missing.py test_missing.py-20070525171057-qr1z4sleurlp9b5v-1
  bzrlib/tests/commands/test_pull.py test_pull.py-20070525144918-cgmunk4ici2krjnd-1
  bzrlib/tests/commands/test_push.py test_push.py-20070525122003-gc1ob0ea0nueoqgj-1
  bzrlib/tests/commands/test_update.py test_update.py-20070910091045-8uyp8v73j926l1g2-1
  bzrlib/tests/transport_util.py transportutil.py-20070525113600-5v2igk89s8fensom-1
-------------- next part --------------
=== modified file 'bzrlib/tests/commands/test_branch.py'
--- a/bzrlib/tests/commands/test_branch.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_branch.py	2007-09-11 14:47:02 +0000
@@ -24,7 +24,7 @@
     def setUp(self):
         super(TestBranch, self).setUp()
         self.make_branch_and_tree('branch')
-        self.install_hooks()
+        self.start_logging_connections()
 
     def test_branch_remote_local(self):
         cmd = cmd_branch()

=== modified file 'bzrlib/tests/commands/test_cat.py'
--- a/bzrlib/tests/commands/test_cat.py	2007-07-22 17:18:05 +0000
+++ b/bzrlib/tests/commands/test_cat.py	2007-09-11 14:47:02 +0000
@@ -47,7 +47,7 @@
         wt1.add('foo')
         wt1.commit('add foo')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_cat()
         cmd.run(self.get_url('branch/foo'))

=== modified file 'bzrlib/tests/commands/test_checkout.py'
--- a/bzrlib/tests/commands/test_checkout.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_checkout.py	2007-09-11 14:47:02 +0000
@@ -24,7 +24,7 @@
     def test_checkout(self):
         self.make_branch_and_tree('branch1')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_checkout()
         cmd.run(self.get_url('branch1'), 'local')

=== modified file 'bzrlib/tests/commands/test_init.py'
--- a/bzrlib/tests/commands/test_init.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_init.py	2007-09-11 14:47:02 +0000
@@ -23,7 +23,7 @@
 
     def setUp(self):
         super(TestInit, self).setUp()
-        self.install_hooks()
+        self.start_logging_connections()
 
     def test_init(self):
         cmd = cmd_init()

=== modified file 'bzrlib/tests/commands/test_init_repository.py'
--- a/bzrlib/tests/commands/test_init_repository.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_init_repository.py	2007-09-11 14:47:02 +0000
@@ -23,7 +23,7 @@
 
     def setUp(self):
         super(TestInitRepository, self).setUp()
-        self.install_hooks()
+        self.start_logging_connections()
 
     def test_init_repository(self):
         cmd = cmd_init_repository()

=== modified file 'bzrlib/tests/commands/test_merge.py'
--- a/bzrlib/tests/commands/test_merge.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_merge.py	2007-09-11 14:47:02 +0000
@@ -29,7 +29,7 @@
         wt2.pull(wt1.branch)
         wt2.commit('empty commit too')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_merge()
         # We don't care about the ouput but 'outf' should be defined

=== modified file 'bzrlib/tests/commands/test_missing.py'
--- a/bzrlib/tests/commands/test_missing.py	2007-08-16 17:36:50 +0000
+++ b/bzrlib/tests/commands/test_missing.py	2007-09-11 14:47:02 +0000
@@ -28,7 +28,7 @@
         wt2.pull(wt1.branch)
         wt2.commit('empty commit too')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_missing()
         # We don't care about the ouput but 'outf' should be defined

=== modified file 'bzrlib/tests/commands/test_pull.py'
--- a/bzrlib/tests/commands/test_pull.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_pull.py	2007-09-11 14:47:02 +0000
@@ -27,7 +27,7 @@
         tip = wt1.commit('empty commit')
         wt2 = self.make_branch_and_tree('branch2')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_pull()
         # We don't care about the ouput but 'outf' should be defined

=== modified file 'bzrlib/tests/commands/test_push.py'
--- a/bzrlib/tests/commands/test_push.py	2007-07-20 16:57:41 +0000
+++ b/bzrlib/tests/commands/test_push.py	2007-09-11 14:47:02 +0000
@@ -24,7 +24,7 @@
     def test_push(self):
         self.make_branch_and_tree('branch')
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         cmd = cmd_push()
         cmd.run(self.get_url('remote'), directory='branch')

=== modified file 'bzrlib/tests/commands/test_update.py'
--- a/bzrlib/tests/commands/test_update.py	2007-09-10 12:12:47 +0000
+++ b/bzrlib/tests/commands/test_update.py	2007-09-11 14:47:02 +0000
@@ -32,7 +32,7 @@
         bind = builtins.cmd_bind()
         bind.run(location=self.get_url('branch1'))
 
-        self.install_hooks()
+        self.start_logging_connections()
 
         update = builtins.cmd_update()
         update.run()

=== modified file 'bzrlib/tests/transport_util.py'
--- a/bzrlib/tests/transport_util.py	2007-07-22 15:44:59 +0000
+++ b/bzrlib/tests/transport_util.py	2007-09-11 14:47:02 +0000
@@ -80,9 +80,9 @@
         url = _hooked_scheme + url[len('sftp'):]
         return url
 
-    def install_hooks(self):
+    def start_logging_connections(self):
         ConnectionHookedTransport.hooks.install_hook('_set_connection',
-                                                     self.set_connection_hook)
+                                                     self._collect_connection)
         # uninstall our hooks when we are finished
         self.addCleanup(self.reset_hooks)
 
@@ -92,7 +92,7 @@
     def reset_connections(self):
         self.connections = []
 
-    def set_connection_hook(self, transport, connection, credentials):
+    def _collect_connection(self, transport, connection, credentials):
         # Note: uncomment the following line and use 'bt' under pdb, that will
         # identify all the connections made including the extraneous ones.
         # import pdb; pdb.set_trace()



More information about the bazaar-commits mailing list