Rev 2797: Review feedback. in http://people.ubuntu.com/~robertc/baz2.0/knits

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/knits

------------------------------------------------------------
revno: 2797
revision-id: robertc at robertcollins.net-20070906014600-zsqflovlwhc52gpv
parent: robertc at robertcollins.net-20070905222501-n5nfbwd3rs21ll11
committer: Robert Collins <robertc at robertcollins.net>
branch nick: knits
timestamp: Thu 2007-09-06 11:46:00 +1000
message:
  Review feedback.
modified:
  bzrlib/errors.py               errors.py-20050309040759-20512168c4e14fbd
  bzrlib/knit.py                 knit.py-20051212171256-f056ac8f0fbe1bd9
=== modified file 'bzrlib/errors.py'
--- a/bzrlib/errors.py	2007-09-05 03:51:59 +0000
+++ b/bzrlib/errors.py	2007-09-06 01:46:00 +0000
@@ -1855,7 +1855,7 @@
 
 
 class ExistingContent(BzrError):
-    """Added in bzrlib 0.92, used by VersionedFile.add_lines."""
+    # Added in bzrlib 0.92, used by VersionedFile.add_lines.
 
     _fmt = "The content being inserted is already present."
 

=== modified file 'bzrlib/knit.py'
--- a/bzrlib/knit.py	2007-09-05 22:25:01 +0000
+++ b/bzrlib/knit.py	2007-09-06 01:46:00 +0000
@@ -201,7 +201,12 @@
 
 
 class PlainKnitContent(KnitContent):
-    """Unannotated content."""
+    """Unannotated content.
+    
+    When annotate[_iter] is called on this content, the same version is reported
+    for all lines. Generally, annotate[_iter] is not useful on PlainKnitContent
+    objects.
+    """
 
     def __init__(self, lines, version_id):
         self._lines = lines
@@ -847,7 +852,7 @@
         if contains_whitespace(version_id):
             raise InvalidRevisionId(version_id, self.filename)
         self.check_not_reserved_id(version_id)
-        # Technically this is a case of LBYL, but:
+        # Technically this is a case of Look Before You Leap, but:
         # - for knits this saves wasted space in the error case
         # - for packs this avoids dead space in the pack
         # - it also avoids undetected poisoning attacks.