Rev 2923: Remove unneeded shortcut in commit's check_pointless logic. in http://people.ubuntu.com/~robertc/baz2.0/commit

Robert Collins robertc at robertcollins.net
Mon Oct 22 22:29:08 BST 2007


At http://people.ubuntu.com/~robertc/baz2.0/commit

------------------------------------------------------------
revno: 2923
revision-id:robertc at robertcollins.net-20071022212902-tpiqbukqzen5lsg4
parent: robertc at robertcollins.net-20071022212521-wac62k68k3quy6om
committer: Robert Collins <robertc at robertcollins.net>
branch nick: commit
timestamp: Tue 2007-10-23 07:29:02 +1000
message:
  Remove unneeded shortcut in commit's check_pointless logic.
modified:
  bzrlib/commit.py               commit.py-20050511101309-79ec1a0168e0e825
=== modified file 'bzrlib/commit.py'
--- a/bzrlib/commit.py	2007-10-22 21:25:21 +0000
+++ b/bzrlib/commit.py	2007-10-22 21:29:02 +0000
@@ -421,10 +421,6 @@
         if (self.basis_revid == revision.NULL_REVISION and
             len(self.builder.new_inventory) == 1):
             raise PointlessCommit()
-        # Shortcut, if the number of entries changes, then we obviously have
-        # a change
-        if len(self.builder.new_inventory) != len(self.basis_inv):
-            return
         # If length == 1, then we only have the root entry. Which means
         # that there is no real difference (only the root could be different)
         if len(self.builder.new_inventory) != 1 and (self.any_entries_changed



More information about the bazaar-commits mailing list