Rev 2891: Review feedback. in http://people.ubuntu.com/~robertc/baz2.0/knits

Robert Collins robertc at robertcollins.net
Tue Oct 9 04:57:52 BST 2007


At http://people.ubuntu.com/~robertc/baz2.0/knits

------------------------------------------------------------
revno: 2891
revision-id: robertc at robertcollins.net-20071009035742-sfpuvvyxewtmajk3
parent: robertc at robertcollins.net-20071005030427-835quoopdu6adviv
committer: Robert Collins <robertc at robertcollins.net>
branch nick: knits
timestamp: Tue 2007-10-09 13:57:42 +1000
message:
  Review feedback.
modified:
  bzrlib/knit.py                 knit.py-20051212171256-f056ac8f0fbe1bd9
=== modified file 'bzrlib/knit.py'
--- a/bzrlib/knit.py	2007-10-05 03:04:27 +0000
+++ b/bzrlib/knit.py	2007-10-09 03:57:42 +0000
@@ -913,8 +913,10 @@
                 store_lines)
         else:
             options.append('fulltext')
+            # isinstance is slower and we have no hierarchy.
             if self.factory.__class__ == KnitPlainFactory:
-                # use the prejoined bytes
+                # Use the already joined bytes saving iteration time in
+                # _record_to_data.
                 size, bytes = self._data._record_to_data(version_id, digest,
                     lines, [line_bytes])
             else:



More information about the bazaar-commits mailing list