Rev 2802: Final review tweaks. in http://people.ubuntu.com/~robertc/baz2.0/commit

Robert Collins robertc at robertcollins.net
Wed Oct 3 05:23:10 BST 2007


At http://people.ubuntu.com/~robertc/baz2.0/commit

------------------------------------------------------------
revno: 2802
revision-id: robertc at robertcollins.net-20071003042301-a8uqkwlqr5owcqbo
parent: robertc at robertcollins.net-20071003000505-ls3k5qm7nw1us6j4
committer: Robert Collins <robertc at robertcollins.net>
branch nick: commit
timestamp: Wed 2007-10-03 14:23:01 +1000
message:
  Final review tweaks.
modified:
  bzrlib/repository.py           rev_storage.py-20051111201905-119e9401e46257e3
=== modified file 'bzrlib/repository.py'
--- a/bzrlib/repository.py	2007-10-03 00:05:05 +0000
+++ b/bzrlib/repository.py	2007-10-03 04:23:01 +0000
@@ -306,13 +306,8 @@
                     # Either there is only a hash change(no hash cache entry,
                     # or same size content change), or there is no change on
                     # this file at all.
-                    # There is a race condition when inserting content into the
-                    # knit though that can result in different content being
-                    # inserted so even though we may have had a hash cache hit
-                    # here we still tell the store the hash we would *not*
-                    # store a new text on, which means that it can avoid for us
-                    # without a race condition and without double-shaing the
-                    # lines.
+                    # Provide the parent's hash to the store layer, so that the
+                    # content is unchanged we will not store a new node.
                     nostore_sha = parent_entry.text_sha1
             if store:
                 # We want to record a new node regardless of the presence or



More information about the bazaar-commits mailing list