Rev 2336: we don't need _inventory_fp. in

John Arbash Meinel john at
Wed Mar 21 18:16:05 GMT 2007


revno: 2336
revision-id: john at
parent: john at
committer: John Arbash Meinel <john at>
branch nick: make_locking_cheaper
timestamp: Wed 2007-03-21 13:15:57 -0500
  we don't need _inventory_fp.
  The bug is that calling self.read_working_inventory() acquires a read lock,
  which has a side effect of reading the working inventory,
  and then it reads the working inventory,
  and then because the overall tree is not locked (this is all happening in WorkingTree.__init__)
  all of this is being thrown away.
  So we end up with 2 inventory reads which will be completely thrown away.
-------------- next part --------------
=== modified file 'bzrlib/'
--- a/bzrlib/	2007-03-21 17:51:42 +0000
+++ b/bzrlib/	2007-03-21 18:15:57 +0000
@@ -280,7 +280,6 @@
             # This will be acquired on lock_read() or lock_write()
             self._inventory_is_modified = False
             self._inventory = None
-            self._inventory_fp = None
             # the caller of __init__ has provided an inventory,
             # we assume they know what they are doing - as its only

More information about the bazaar-commits mailing list