Rev 2315: (Vincent Ladeuil) invalid proxy vars should not cause a traceback (bug #87765) in /home/pqm/archives/thelove/bzr/+trunk/

[Canonical.com Patch Queue Manager]

------------------------------------------------------------
revno: 2315
revision-id: pqm at pqm.ubuntu.com-20070305220713-41e023034592cca1
parent: pqm at pqm.ubuntu.com-20070305202715-ac49286871b5e2a8
parent: john at arbash-meinel.com-20070305205142-3xhccyveuakkrj87
committer: Canonical.com Patch Queue Manager<pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Mon 2007-03-05 22:07:13 +0000
message:
  (Vincent Ladeuil) invalid proxy vars should not cause a traceback (bug #87765)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/test_http.py      testhttp.py-20051018020158-b2eef6e867c514d9
  bzrlib/transport/http/_urllib2_wrappers.py _urllib2_wrappers.py-20060913231729-ha9ugi48ktx481ao-1
    ------------------------------------------------------------
    merged: john at arbash-meinel.com-20070305205142-3xhccyveuakkrj87
    parent: pqm at pqm.ubuntu.com-20070305202715-ac49286871b5e2a8
    parent: v.ladeuil+lp at free.fr-20070225121053-eh4u4ydukn97ht9q
    committer: John Arbash Meinel <john at arbash-meinel.com>
    branch nick: jam-integration
    timestamp: Mon 2007-03-05 14:51:42 -0600
    message:
      (Vincent Ladeuil) invalid proxy vars should not cause a traceback (bug #87765)
    ------------------------------------------------------------
    merged: v.ladeuil+lp at free.fr-20070225121053-eh4u4ydukn97ht9q
    parent: pqm at pqm.ubuntu.com-20070222144505-5f7551602cad9332
    committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
    branch nick: 87765
    timestamp: Sun 2007-02-25 13:10:53 +0100
    message:
      Fix bug #87765: proxy env variables without scheme should cause
      bzr to issue traceback.
      
      * bzrlib/tests/test_http.py:
      (TestHttpProxyWhiteBox.test_invalid_proxy): New test for an proxy
      not mentionning a scheme.
      (TestProxyHttpServer.setUp): New attribute with the proxy raw
      address.
      (TestProxyHttpServer.test_http_proxy_without_scheme): New test
      checking that InvalidURL is raised when an env variable specifies
      no scheme.
      (TestProxyHttpServer_pycurl): pycurl ignores invalid proxies,
      check it in case it changes in the future.
      
      * bzrlib/transport/http/_urllib2_wrappers.py:
      (ProxyHandler.set_proxy): If we can't find a host in the proxy env
      variable, raises InvalidURL.