Rev 2317: TextStores don't require Unicode file_ids anymore. test_a passes in http://bzr.arbash-meinel.com/branches/bzr/0.15-dev/unicode_id_warnings
John Arbash Meinel
john at arbash-meinel.com
Fri Mar 2 17:11:00 GMT 2007
At http://bzr.arbash-meinel.com/branches/bzr/0.15-dev/unicode_id_warnings
------------------------------------------------------------
revno: 2317
revision-id: john at arbash-meinel.com-20070302171052-yn19ifc2f323tvqs
parent: john at arbash-meinel.com-20070302170940-52wmugtm01zpzma2
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: unicode_id_warnings
timestamp: Fri 2007-03-02 11:10:52 -0600
message:
TextStores don't require Unicode file_ids anymore. test_a passes
modified:
bzrlib/store/revision/text.py text.py-20060303020652-e49155f0da4d14ab
-------------- next part --------------
=== modified file 'bzrlib/store/revision/text.py'
--- a/bzrlib/store/revision/text.py 2007-02-10 02:48:43 +0000
+++ b/bzrlib/store/revision/text.py 2007-03-02 17:10:52 +0000
@@ -67,16 +67,11 @@
def _add_revision(self, revision, revision_as_file, transaction):
"""Template method helper to store revision in this store."""
- # TODO: jam 20070209 text_store.add() still requires a unicode file id
- unicode_revision_id = cache_utf8.decode(revision.revision_id)
- self.text_store.add(revision_as_file, unicode_revision_id)
+ self.text_store.add(revision_as_file, revision.revision_id)
def add_revision_signature_text(self, revision_id, signature_text, transaction):
"""See RevisionStore.add_revision_signature_text()."""
- # TODO: jam 20070209 text_store.add() still requires a unicode file id
- revision_id_unicode = cache_utf8.decode(revision_id)
- self.text_store.add(StringIO(signature_text), revision_id_unicode,
- "sig")
+ self.text_store.add(StringIO(signature_text), revision_id, "sig")
def all_revision_ids(self, transaction):
"""See RevisionStore.all_revision_ids()."""
More information about the bazaar-commits
mailing list