Rev 2525: Revert logging just to stderr in commit as broke unicode filenames (#120930) in http://bazaar.launchpad.net/~ian-clatworthy/bzr/bzr0.17

Ian Clatworthy ian.clatworthy at internode.on.net
Mon Jun 18 03:25:20 BST 2007


At http://bazaar.launchpad.net/~ian-clatworthy/bzr/bzr0.17

------------------------------------------------------------
revno: 2525
revision-id: ian.clatworthy at internode.on.net-20070618022513-md6e0xyqofhq4m7h
parent: ian.clatworthy at internode.on.net-20070618015632-ug6lxcn6npzcqdym
committer: Ian Clatworthy <ian.clatworthy at internode.on.net>
branch nick: bzr.0.17
timestamp: Mon 2007-06-18 12:25:13 +1000
message:
  Revert logging just to stderr in commit as broke unicode filenames (#120930)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/commit.py               commit.py-20050511101309-79ec1a0168e0e825
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2007-06-18 01:56:32 +0000
+++ b/NEWS	2007-06-18 02:25:13 +0000
@@ -5,6 +5,9 @@
     * Fix crash of commit due to wrong lookup of filesystem encoding.
       (Colin Watson, #120647)
 
+    * Revert logging just to stderr in commit as broke unicode filenames.
+      (Aaron Bentley, Ian Clatworthy, #120930)
+
 
 bzr 0.17rc1  2007-06-12
 

=== modified file 'bzrlib/commit.py'
--- a/bzrlib/commit.py	2007-06-06 05:56:03 +0000
+++ b/bzrlib/commit.py	2007-06-18 02:25:13 +0000
@@ -109,15 +109,9 @@
     def _note(self, format, *args):
         """Output a message.
 
-        Messages are output by writing directly to stderr instead of
-        using bzrlib.trace.note(). The latter constantly updates the
-        log file as we go causing an unnecessary performance hit.
-
-        Subclasses may choose to override this method but need to be aware
-        of its potential impact on performance.
+        Subclasses may choose to override this method.
         """
-        bzrlib.ui.ui_factory.clear_term()
-        sys.stderr.write((format + "\n") % args)
+        note(format, *args)
 
     def snapshot_change(self, change, path):
         if change == 'unchanged':



More information about the bazaar-commits mailing list