Rev 483: Add another check in file:///home/jelmer/bzr-svn/0.4/

Jelmer Vernooij jelmer at samba.org
Sun Jun 17 18:07:27 BST 2007


------------------------------------------------------------
revno: 483
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: 0.4
timestamp: Sun 2007-06-17 19:07:06 +0200
message:
  Add another check
modified:
  repository.py
  tests/test_repos.py
=== modified file 'repository.py'
--- a/repository.py	2007-06-17 16:39:02 +0000
+++ b/repository.py	2007-06-17 17:07:06 +0000
@@ -62,6 +62,9 @@
     except ValueError:
         raise errors.InvalidPropertyValue(SVN_PROP_BZR_REVISION_ID, 
                 "missing space")
+    if revid == "":
+        raise errors.InvalidPropertyValue(SVN_PROP_BZR_REVISION_ID,
+                "empty revision id")
     return (int(revno), revid)
 
 

=== modified file 'tests/test_repos.py'
--- a/tests/test_repos.py	2007-06-17 16:39:02 +0000
+++ b/tests/test_repos.py	2007-06-17 17:07:06 +0000
@@ -2410,3 +2410,7 @@
     def test_parse_revid_property_invalid(self):
         self.assertRaises(InvalidPropertyValue, 
                 lambda: parse_revid_property("blabla"))
+
+    def test_parse_revid_property_empty_revid(self):
+        self.assertRaises(InvalidPropertyValue, 
+                lambda: parse_revid_property("2 "))




More information about the bazaar-commits mailing list