Rev 2623: Some review feedback. in http://people.ubuntu.com/~robertc/baz2.0/repo-write-group

Robert Collins robertc at robertcollins.net
Tue Jul 31 01:52:15 BST 2007


At http://people.ubuntu.com/~robertc/baz2.0/repo-write-group

------------------------------------------------------------
revno: 2623
revision-id: robertc at robertcollins.net-20070731005211-vcncoanpgu8qnu03
parent: robertc at robertcollins.net-20070720022713-z6x6cns4dy1mzhpk
committer: Robert Collins <robertc at robertcollins.net>
branch nick: repo-write-group
timestamp: Tue 2007-07-31 10:52:11 +1000
message:
  Some review feedback.
modified:
  bzrlib/remote.py               remote.py-20060720103555-yeeg2x51vn0rbtdp-1
  bzrlib/repository.py           rev_storage.py-20051111201905-119e9401e46257e3
=== modified file 'bzrlib/remote.py'
--- a/bzrlib/remote.py	2007-07-20 02:27:13 +0000
+++ b/bzrlib/remote.py	2007-07-31 00:52:11 +0000
@@ -253,7 +253,7 @@
         """complete a write group on the decorated repository.
         
         Smart methods peform operations in a single step so this api
-        is not really applicable except as a compatability thunk
+        is not really applicable except as a compatibility thunk
         for older plugins that don't use e.g. the CommitBuilder
         facility.
         """
@@ -264,7 +264,7 @@
         """complete a write group on the decorated repository.
         
         Smart methods peform operations in a single step so this api
-        is not really applicable except as a compatability thunk
+        is not really applicable except as a compatibility thunk
         for older plugins that don't use e.g. the CommitBuilder
         facility.
         """
@@ -445,7 +445,7 @@
         """Start a write group on the decorated repository.
         
         Smart methods peform operations in a single step so this api
-        is not really applicable except as a compatability thunk
+        is not really applicable except as a compatibility thunk
         for older plugins that don't use e.g. the CommitBuilder
         facility.
         """

=== modified file 'bzrlib/repository.py'
--- a/bzrlib/repository.py	2007-07-20 02:27:13 +0000
+++ b/bzrlib/repository.py	2007-07-31 00:52:11 +0000
@@ -482,6 +482,7 @@
 
         A write lock is required around the start_write_group/commit_write_group
         for the support of lock-requiring repository formats.
+        :return: None.
         """
         if not self.is_locked() or self.control_files._lock_mode != 'w':
             raise errors.NotWriteLocked(self)
@@ -1145,7 +1146,7 @@
 
     inv = revision_tree.inventory
     entries = inv.iter_entries()
-    # backwards compatability hack: skip the root id.
+    # backwards compatibility hack: skip the root id.
     if not repository.supports_rich_root():
         path, root = entries.next()
         if root.revision != rev.revision_id:



More information about the bazaar-commits mailing list