Rev 2658: Note unlock defect. in http://people.ubuntu.com/~robertc/baz2.0/repository

Robert Collins robertc at robertcollins.net
Sun Jul 15 09:53:56 BST 2007


At http://people.ubuntu.com/~robertc/baz2.0/repository

------------------------------------------------------------
revno: 2658
revision-id: robertc at robertcollins.net-20070715085353-hvsi3o21ybfny9ai
parent: robertc at robertcollins.net-20070715084605-jgwqobnbo0i4i4rd
committer: Robert Collins <robertc at robertcollins.net>
branch nick: repository
timestamp: Sun 2007-07-15 18:53:53 +1000
message:
  Note unlock defect.
modified:
  bzrlib/repofmt/knitrepo.py     knitrepo.py-20070206081537-pyy4a00xdas0j4pf-1
=== modified file 'bzrlib/repofmt/knitrepo.py'
--- a/bzrlib/repofmt/knitrepo.py	2007-07-15 08:30:05 +0000
+++ b/bzrlib/repofmt/knitrepo.py	2007-07-15 08:53:53 +0000
@@ -301,6 +301,11 @@
     This class works by replacing the original RevisionStore.
     We need to do this because the GraphKnitRevisionStore is less
     isolated in its layering - it uses services from the repo.
+
+    DEFECTS:
+     - unlock writes an index even on error. This is fine while we are writing
+       data to knits, but we really should not use unlock to trigger writes,
+       rather operations should finish explicitly.
     """
 
     def __init__(self, repo, revisionstore):



More information about the bazaar-commits mailing list