Rev 222: Fix whitespace, add comment. in file:///data/jelmer/bzr-gtk/trunk/

Jelmer Vernooij jelmer at samba.org
Sun Jul 15 21:52:59 BST 2007


At file:///data/jelmer/bzr-gtk/trunk/

------------------------------------------------------------
revno: 222
revision-id: jelmer at samba.org-20070715150506-1uemecr5kt7d4kvg
parent: jelmer at samba.org-20070715150233-zcrxg8t2fdj74wqh
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: trunk
timestamp: Sun 2007-07-15 18:05:06 +0300
message:
  Fix whitespace, add comment.
modified:
  HACKING                        hacking-20070406144810-j0y4o8rc07bo7f2h-1
  push.py                        push.py-20060721181724-0mfkrqwpsa09q1t3-4
=== modified file 'HACKING'
--- a/HACKING	2007-04-06 14:49:24 +0000
+++ b/HACKING	2007-07-15 15:05:06 +0000
@@ -1,7 +1,11 @@
-The Bazaar hacking guide (HACKING in the source tarball) should be applicable to bzr-gtk as well, with a few exceptions listed in this file.
-
-bzr-gtk is a set of GTK+ frontends to Bazaar. Integration between components and with the system is highly welcome. 
-
-The GNOME Human Interface Guidelines (http://developer.gnome.org/projects/gup/hig/) should be followed where possible.
+The Bazaar hacking guide (HACKING in the source tarball) should be applicable 
+to bzr-gtk as well, with a few exceptions listed in this file.
+
+bzr-gtk is a set of GTK+ frontends to Bazaar. Integration between components 
+and with the system is highly welcome. 
+
+The GNOME Human Interface Guidelines 
+(http://developer.gnome.org/projects/gup/hig/) should be followed where 
+possible.
 
 Please update the NEWS file when closing bugs or adding new features.

=== modified file 'push.py'
--- a/push.py	2007-02-03 15:04:56 +0000
+++ b/push.py	2007-07-15 15:05:06 +0000
@@ -113,8 +113,10 @@
         m = _urlRE.match(url)
         if m:
             proto = m.groupdict()['proto']
-            if (proto == 'sftp') or (proto == 'file') or (proto == 'ftp'):
-                # have write acces (most probably)
+            # FIXME: This should ask the transport or branch rather than 
+            # guessing using regular expressions. JRV 20070714
+            if proto in ('sftp', 'file', 'ftp'):
+                # have write access (most probably)
                 self._image_test.set_from_stock(gtk.STOCK_YES, 4)
                 self._label_test.set_markup(_('<b>Write access is probably available</b>'))
             else:




More information about the bazaar-commits mailing list