Rev 2715: Better assertSubset implementation in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 2715
revision-id: pqm at pqm.ubuntu.com-20070816100939-8cm630hgejoaur5a
parent: pqm at pqm.ubuntu.com-20070816081628-m60gvacfft5dw7wj
parent: mbp at sourcefrog.net-20070816073357-ln8v8w6b86tjyet5
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Thu 2007-08-16 11:09:39 +0100
message:
  Better assertSubset implementation
modified:
  bzrlib/tests/__init__.py       selftest.py-20050531073622-8d0e3c8845c97a64
    ------------------------------------------------------------
    revno: 2713.1.1
    merged: mbp at sourcefrog.net-20070816073357-ln8v8w6b86tjyet5
    parent: pqm at pqm.ubuntu.com-20070816055011-tnjdmdi948uyvz6a
    committer: Martin Pool <mbp at sourcefrog.net>
    branch nick: assert-subset
    timestamp: Thu 2007-08-16 17:33:57 +1000
    message:
      Better assertSubset implementation
=== modified file 'bzrlib/tests/__init__.py'
--- a/bzrlib/tests/__init__.py	2007-08-15 01:16:12 +0000
+++ b/bzrlib/tests/__init__.py	2007-08-16 07:33:57 +0000
@@ -863,10 +863,7 @@
 
     def assertSubset(self, sublist, superlist):
         """Assert that every entry in sublist is present in superlist."""
-        missing = []
-        for entry in sublist:
-            if entry not in superlist:
-                missing.append(entry)
+        missing = set(sublist) - set(superlist)
         if len(missing) > 0:
             raise AssertionError("value(s) %r not present in container %r" % 
                                  (missing, superlist))