Rev 2439: Cosmetic changes. in http://bazaar.launchpad.net/~bzr/bzr/bzr.http.auth

[Vincent Ladeuil]

At http://bazaar.launchpad.net/~bzr/bzr/bzr.http.auth

------------------------------------------------------------
revno: 2439
revision-id: v.ladeuil+lp at free.fr-20070424100523-3odqlqm2nnoc8gdu
parent: v.ladeuil+lp at free.fr-20070424095159-pnxwqfn1og3bqg5e
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: bzr.http.auth
timestamp: Tue 2007-04-24 12:05:23 +0200
message:
  Cosmetic changes.
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/HTTPTestUtil.py   HTTPTestUtil.py-20050914180604-247d3aafb7a43343
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2007-04-24 09:51:59 +0000
+++ b/NEWS	2007-04-24 10:05:23 +0000
@@ -246,9 +246,8 @@
       Andrew Bennetts, Martin Pool, Jonathan Lange)
 
     * Refactored proxy and authentication handling to simplify the
-      implementation of new auth schemes for both http and proxy.
-      (vincent Ladeuil)
-
+      implementation of new auth schemes for both http and proxy. 
+      (Vincent Ladeuil)
 
 bzr 0.15 2007-04-01
 

=== modified file 'bzrlib/tests/HTTPTestUtil.py'
--- a/bzrlib/tests/HTTPTestUtil.py	2007-04-22 16:32:04 +0000
+++ b/bzrlib/tests/HTTPTestUtil.py	2007-04-24 10:05:23 +0000
@@ -350,8 +350,8 @@
                          'Basic realm="%s"' % tcs.auth_realm)
 
 
-# FIXME: We should send an Authentication-Info header too when
-# the autheticaion is succesful
+# FIXME: We could send an Authentication-Info header too when
+# the authentication is succesful
 
 class DigestAuthRequestHandler(AuthRequestHandler):
     """Implements the digest authentication of a request.
@@ -421,6 +421,11 @@
         return expected_password is not None and password == expected_password
 
 
+# FIXME: There is some code duplication with
+# _urllib2_wrappers.py.DigestAuthHandler. If that duplciation
+# grows, it may require a refactoring. Also, we don't implement
+# SHA algorithm nor MD5-sess here, but that does not seem worth
+# it.
 class DigestAuthServer(AuthServer):
     """A digest authentication server"""