Rev 2445: ``bzr serve`` now listens on interface 0.0.0.0 by default, making it serve in file:///home/robertc/source/baz/hpss-defaultport/

[Robert Collins]

At file:///home/robertc/source/baz/hpss-defaultport/

------------------------------------------------------------
revno: 2445
revision-id: robertc at robertcollins.net-20070423043850-syh9c5j0evr48gam
parent: robertc at robertcollins.net-20070423042856-5ehxo2patgw2h4nj
committer: Robert Collins <robertc at robertcollins.net>
branch nick: hpss-defaultport
timestamp: Mon 2007-04-23 14:38:50 +1000
message:
  ``bzr serve`` now listens on interface 0.0.0.0 by default, making it serve
  out to the local LAN and fixing bug 98918. (Robert Collins)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/builtins.py             builtins.py-20050830033751-fc01482b9ca23183
  bzrlib/transport/remote.py     ssh.py-20060608202016-c25gvf1ob7ypbus6-1
=== modified file 'NEWS'
--- a/NEWS	2007-04-23 04:28:56 +0000
+++ b/NEWS	2007-04-23 04:38:50 +0000
@@ -43,6 +43,9 @@
       #107125) and also update the blurb about the hpss' current status.
       (Robert Collins).
 
+    * ``bzr serve`` now listens on interface 0.0.0.0 by default, making it
+      serve out to the local LAN and fixing bug 98918. (Robert Collins)
+
   INTERNALS:
 
     * bzrlib API compatability with 0.8 has been dropped, cleaning up some

=== modified file 'bzrlib/builtins.py'
--- a/bzrlib/builtins.py	2007-04-21 14:15:08 +0000
+++ b/bzrlib/builtins.py	2007-04-23 04:38:50 +0000
@@ -3291,7 +3291,7 @@
         from bzrlib.smart import medium, server
         from bzrlib.transport import get_transport
         from bzrlib.transport.chroot import ChrootServer
-        from bzrlib.transport.remote import BZR_DEFAULT_PORT
+        from bzrlib.transport.remote import BZR_DEFAULT_PORT, BZR_DEFAULT_INTERFACE
         if directory is None:
             directory = os.getcwd()
         url = urlutils.local_path_to_url(directory)
@@ -3304,14 +3304,12 @@
             smart_server = medium.SmartServerPipeStreamMedium(
                 sys.stdin, sys.stdout, t)
         else:
+            host = BZR_DEFAULT_INTERFACE
             if port is None:
                 port = BZR_DEFAULT_PORT
-                host = '127.0.0.1'
             else:
                 if ':' in port:
                     host, port = port.split(':')
-                else:
-                    host = '127.0.0.1'
                 port = int(port)
             smart_server = server.SmartTCPServer(t, host=host, port=port)
             print 'listening on port: ', smart_server.port

=== modified file 'bzrlib/transport/remote.py'
--- a/bzrlib/transport/remote.py	2007-04-16 17:49:35 +0000
+++ b/bzrlib/transport/remote.py	2007-04-23 04:38:50 +0000
@@ -39,6 +39,7 @@
 
 
 # Port 4155 is the default port for bzr://, registered with IANA.
+BZR_DEFAULT_INTERFACE = '0.0.0.0'
 BZR_DEFAULT_PORT = 4155