<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 4, 2016 at 10:23 PM, Christian Boltz <span dir="ltr"><<a href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
according to the discussion with John on IRC, exec log events for<br>
directories should never happen, therefore let handle_children()<br>
raise an exception.<br>
<br>
<br>
[ 69-error-out-on-dir-exec.diff ]<br>
<br>
--- utils/apparmor/aa.py        2016-02-04 01:21:33.010848414 +0100<br>
+++ utils/apparmor/aa.py        2016-02-04 17:49:00.985255184 +0100<br>
@@ -1208,8 +1203,7 @@<br>
<br>
                 if mode & str_to_mode('x'):<br>
                     if os.path.isdir(exec_target):<br>
-                        mode = mode - apparmor.aamode.ALL_AA_EXEC_TYPE<br>
-                        mode = mode | str_to_mode('ix')<br>
+                        raise AppArmorBug('exec permissions requested for directory %s. This should not happen - please open a bugreport!' % exec_target)<br>
                     else:<br>
                         do_execute = True<br>
<br></blockquote><div>Thanks for the patch.<br></div><div><br>Acked-by: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com" target="_blank">kgupta8592@gmail.com</a>> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
> > "Frontpage" is a M$ WYSIWYG web page creation program.<br>
Would you like some Wine with that ActiveX?<br>
You must have a different Outlook(tm) on things, I thought it was an<br>
Excel(tm)lent Word(tm). [>> Carl Hartung and Peter Flodin in opensuse]<br>
</font></span><br>--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij Gupta<br></div></div>
</div></div>