<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 20, 2015 at 1:32 AM, Christian Boltz <span dir="ltr"><<a href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
creating a file is in theory covered by the 'a' permission, however<br>
discussion on IRC brought up that depending on the open flags it might<br>
not be enough (real-world example: creating the apache pid file).<br>
<br>
Therefore change the mapping to 'w' permissions - that might allow more<br>
than needed in some cases, but makes sure the profile always works.<br>
<br>
<br>
I propose this patch for 2.9, 2.10 and trunk<br>
<br>
<br>
[ 23-map-create-to-w.diff ]<br>
<br>
=== modified file ./utils/apparmor/logparser.py<br>
--- utils/apparmor/logparser.py 2015-11-19 17:42:26.333879063 +0100<br>
+++ utils/apparmor/logparser.py 2015-11-19 20:51:49.139296808 +0100<br>
@@ -296,15 +296,15 @@<br>
self.debug_logger.debug('UNHANDLED (missing request_mask): %s' % e)<br>
return None<br>
<br>
- # Map c (create) to a and d (delete) to w (logging is more detailed than the profile language)<br>
+ # Map c (create) and d (delete) to w (logging is more detailed than the profile language)<br>
rmask = e['request_mask']<br>
- rmask = rmask.replace('c', 'a')<br>
+ rmask = rmask.replace('c', 'w')<br>
rmask = rmask.replace('d', 'w')<br>
if not validate_log_mode(hide_log_mode(rmask)):<br>
raise AppArmorException(_('Log contains unknown mode %s') % rmask)<br>
<br>
dmask = e['denied_mask']<br>
- dmask = dmask.replace('c', 'a')<br>
+ dmask = dmask.replace('c', 'w')<br>
dmask = dmask.replace('d', 'w')<br>
if not validate_log_mode(hide_log_mode(dmask)):<br>
raise AppArmorException(_('Log contains unknown mode %s') % dmask)<br>
<br>
<br></blockquote><div><br>Acked-by: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com" target="_blank">kgupta8592@gmail.com</a>> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
Warum nochmal benutzen alle Procmail? Das ist eine Art Quiz, oder?<br>
Wer die unleserlichtste Regel erstellt, bekommt einen Preis?<br>
[Thorsten Haude in suse-linux]<br>
<br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij Gupta<br></div></div>
</div></div>